Skip to content

Inference | Lazy compile UVM allocator. - #1977

Merged
lmcafee-nvidia merged 23 commits into
NVIDIA:mainfrom
lmcafee-nvidia:lmcafee/lazy-uvm-compile
Nov 3, 2025
Merged

Inference | Lazy compile UVM allocator.#1977
lmcafee-nvidia merged 23 commits into
NVIDIA:mainfrom
lmcafee-nvidia:lmcafee/lazy-uvm-compile

Conversation

@lmcafee-nvidia

Copy link
Copy Markdown
Contributor

What does this PR do ?

Lazy compile UVM allocator in megatron/core/inference/unified_memory.py. Previously, this was being compiled for any import of megatron.core.__init__.py. This MR changes this to only compile the UVM allocator on its first use.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@lmcafee-nvidia lmcafee-nvidia added this to the Core 0.15 milestone Oct 27, 2025
@lmcafee-nvidia
lmcafee-nvidia requested a review from tdene October 27, 2025 16:28
@lmcafee-nvidia lmcafee-nvidia self-assigned this Oct 27, 2025
@lmcafee-nvidia
lmcafee-nvidia requested review from a team as code owners October 27, 2025 16:28
@copy-pr-bot

copy-pr-bot Bot commented Oct 27, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Comment thread megatron/core/inference/unified_memory.py Outdated
@lmcafee-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test ec67b9b

@lmcafee-nvidia lmcafee-nvidia added the Final Review PR is in the "final review" stage label Oct 28, 2025
@lmcafee-nvidia
lmcafee-nvidia requested review from jaredcasper and removed request for jaredcasper October 28, 2025 13:17
@lmcafee-nvidia
lmcafee-nvidia requested review from a team as code owners October 30, 2025 19:33
@lmcafee-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 7ec1b89

@ko3n1g

ko3n1g commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

/ok to test acc3706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants