Skip to content

Update dev branch codeowners - #1963

Merged
chtruong814 merged 1 commit into
NVIDIA:devfrom
chtruong814:chtruong/update-dev-codeowners
Oct 27, 2025
Merged

Update dev branch codeowners#1963
chtruong814 merged 1 commit into
NVIDIA:devfrom
chtruong814:chtruong/update-dev-codeowners

Conversation

@chtruong814

Copy link
Copy Markdown
Contributor

What does this PR do ?

Update dev branch codeowners

  • NeMo or Devtech by default are codeowners for everything
  • Set CI code owners to certain directories and files only.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
chtruong814 requested a review from a team as a code owner October 27, 2025 03:56
@ko3n1g ko3n1g added this to the Core 0.16 milestone Oct 27, 2025
@chtruong814
chtruong814 requested a review from ko3n1g October 27, 2025 03:58

@ko3n1g ko3n1g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chtruong814
chtruong814 merged commit eb07b69 into NVIDIA:dev Oct 27, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants