Skip to content

Ko3n1g/ci/fix main on eos #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ko3n1g merged 5 commits into from
Oct 25, 2025
Merged

Ko3n1g/ci/fix main on eos #1938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53a1918
ci: Update golden values
ko3n1g Oct 25, 2025
f1dc801
fix
ko3n1g Oct 25, 2025
36617e0
golden
ko3n1g Oct 25, 2025
f254e6d
update
ko3n1g Oct 25, 2025
c0487f2
update
ko3n1g Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 5 additions & 28 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,41 +31,18 @@ flowchart LR

#### (Step 1): Add PR label `Expert Review`

#### (Step 2): Assign expert reviewers

Assign the expert reviewers that correspond to the areas the PR touches (if no match, assign someone from `DEFAULT`):

- Model:
- [ ] Bert: `aot@nvidia.com`
- [ ] GPT: `ksanthanam@nvidia.com`
- [ ] MoE: `akhattar@nvidia.com`, `vkorthikanti@nvidia.com`, `ykarnati@nvidia.com`, `shiqingf@nvidia.com`, `xiny@nvidia.com`, `zijiey@nvidia.com`
- [ ] Multimodal: `trintamaki@nvidia.com`
- [ ] Retro: `lmcafee@nvidia.com`
- [ ] T5: `huvu@nvidia.com`
- Distributed:
- [ ] Distributed Checkpointing: `skierat@nvidia.com`, `mblaz@nvidia.com`, `dpykhtar@nvidia.com`
- [ ] Distributed optimizer: `slym@nvidia.com`
- [ ] Inference: `vkorthikanti@nvidia.com`
- [ ] Quantization and Inference (QAT): `chenhany@nvidia.com`
- Parallelism:
- [ ] Context Parallelism: `boxiangw@nvidia.com`, `xren@nvidia.com`
- [ ] Pipeline Parallelism: `xren@nvidia.com`
- Transformer: `ksanthanam@nvidia.com`
- Post-training: `chenhany@nvidia.com`, `aanoosheh@nvidia.com`, `kmorabia@nvidia.com`
- [ ] Datasets: `jkamalu@nvidia.com`
- [ ] Tests: okoenig, donghyukc, pagaray, chtruong
- [ ] __DEFAULT__: shanmugamr jcasper eharper okoenig
#### (Step 2): Collect the expert reviewers reviews

1. Attach the `Expert Review` label when your PR is ready for review.
2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

:warning: Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

#### (Step 3): Final Review

1. Add `Final Review` label
2. Assign

- ADLR: `jcasper@nvidia.com` || `dnarayanan@nvidia.com` || `vkorthikanti@nvidia.com`
- NeMo: `eharper@nvidia.com` || `shanmugamr@nvidia.com` || `ansubramania@nvidia.com` || `yuya@nvidia.com`
2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

#### (Optional Step 4): Cherry-pick into release branch

Expand Down
300 changes: 150 additions & 150 deletions ...st_cases/gpt/gpt3_mcore_te_tp1_pp4_vp1_tunable_overlap/golden_values_dev_dgxh100_eos.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,170 +118,170 @@
"end_step": 50,
"step_interval": 1,
"values": {
"1": 759681536.0,
"2": 759681536.0,
"3": 759681536.0,
"4": 759681536.0,
"5": 759681536.0,
"6": 759681536.0,
"7": 759681536.0,
"8": 759681536.0,
"9": 759681536.0,
"10": 759681536.0,
"11": 759681536.0,
"12": 759681536.0,
"13": 759681536.0,
"14": 759681536.0,
"15": 759681536.0,
"16": 759681536.0,
"17": 759681536.0,
"18": 759681536.0,
"19": 759681536.0,
"20": 759681536.0,
"21": 759681536.0,
"22": 759681536.0,
"23": 759681536.0,
"24": 759681536.0,
"25": 759681536.0,
"26": 759681536.0,
"27": 759681536.0,
"28": 759681536.0,
"29": 759681536.0,
"30": 759681536.0,
"31": 759681536.0,
"32": 759681536.0,
"33": 759681536.0,
"34": 759681536.0,
"35": 759681536.0,
"36": 759681536.0,
"37": 759681536.0,
"38": 759681536.0,
"39": 759681536.0,
"40": 759681536.0,
"41": 759681536.0,
"42": 759681536.0,
"43": 759681536.0,
"44": 759681536.0,
"45": 759681536.0,
"46": 759681536.0,
"47": 759681536.0,
"48": 759681536.0,
"49": 759681536.0,
"50": 759681536.0
"1": 759682560.0,
"2": 759682560.0,
"3": 759682560.0,
"4": 759682560.0,
"5": 759682560.0,
"6": 759682560.0,
"7": 759682560.0,
"8": 759682560.0,
"9": 759682560.0,
"10": 759682560.0,
"11": 759682560.0,
"12": 759682560.0,
"13": 759682560.0,
"14": 759682560.0,
"15": 759682560.0,
"16": 759682560.0,
"17": 759682560.0,
"18": 759682560.0,
"19": 759682560.0,
"20": 759682560.0,
"21": 759682560.0,
"22": 759682560.0,
"23": 759682560.0,
"24": 759682560.0,
"25": 759682560.0,
"26": 759682560.0,
"27": 759682560.0,
"28": 759682560.0,
"29": 759682560.0,
"30": 759682560.0,
"31": 759682560.0,
"32": 759682560.0,
"33": 759682560.0,
"34": 759682560.0,
"35": 759682560.0,
"36": 759682560.0,
"37": 759682560.0,
"38": 759682560.0,
"39": 759682560.0,
"40": 759682560.0,
"41": 759682560.0,
"42": 759682560.0,
"43": 759682560.0,
"44": 759682560.0,
"45": 759682560.0,
"46": 759682560.0,
"47": 759682560.0,
"48": 759682560.0,
"49": 759682560.0,
"50": 759682560.0
}
},
"mem-max-allocated-bytes": {
"start_step": 1,
"end_step": 50,
"step_interval": 1,
"values": {
"1": 4340902912.0,
"2": 4622614528.0,
"3": 4622614528.0,
"4": 4622614528.0,
"5": 4622614528.0,
"6": 4622614528.0,
"7": 4622614528.0,
"8": 4622614528.0,
"9": 4622614528.0,
"10": 4622614528.0,
"11": 4622614528.0,
"12": 4622614528.0,
"13": 4622614528.0,
"14": 4622614528.0,
"15": 4622614528.0,
"16": 4622614528.0,
"17": 4622614528.0,
"18": 4622614528.0,
"19": 4622614528.0,
"20": 4622614528.0,
"21": 4622614528.0,
"22": 4622614528.0,
"23": 4622614528.0,
"24": 4622614528.0,
"25": 4622614528.0,
"26": 4622614528.0,
"27": 4622614528.0,
"28": 4622614528.0,
"29": 4622614528.0,
"30": 4622614528.0,
"31": 4622614528.0,
"32": 4622614528.0,
"33": 4622614528.0,
"34": 4622614528.0,
"35": 4622614528.0,
"36": 4622614528.0,
"37": 4622614528.0,
"38": 4622614528.0,
"39": 4622614528.0,
"40": 4622614528.0,
"41": 4622614528.0,
"42": 4622614528.0,
"43": 4622614528.0,
"44": 4622614528.0,
"45": 4622614528.0,
"46": 4622614528.0,
"47": 4622614528.0,
"48": 4622614528.0,
"49": 4622614528.0,
"50": 4622614528.0
"1": 4340903936.0,
"2": 4622615552.0,
"3": 4622615552.0,
"4": 4622615552.0,
"5": 4622615552.0,
"6": 4622615552.0,
"7": 4622615552.0,
"8": 4622615552.0,
"9": 4622615552.0,
"10": 4622615552.0,
"11": 4622615552.0,
"12": 4622615552.0,
"13": 4622615552.0,
"14": 4622615552.0,
"15": 4622615552.0,
"16": 4622615552.0,
"17": 4622615552.0,
"18": 4622615552.0,
"19": 4622615552.0,
"20": 4622615552.0,
"21": 4622615552.0,
"22": 4622615552.0,
"23": 4622615552.0,
"24": 4622615552.0,
"25": 4622615552.0,
"26": 4622615552.0,
"27": 4622615552.0,
"28": 4622615552.0,
"29": 4622615552.0,
"30": 4622615552.0,
"31": 4622615552.0,
"32": 4622615552.0,
"33": 4622615552.0,
"34": 4622615552.0,
"35": 4622615552.0,
"36": 4622615552.0,
"37": 4622615552.0,
"38": 4622615552.0,
"39": 4622615552.0,
"40": 4622615552.0,
"41": 4622615552.0,
"42": 4622615552.0,
"43": 4622615552.0,
"44": 4622615552.0,
"45": 4622615552.0,
"46": 4622615552.0,
"47": 4622615552.0,
"48": 4622615552.0,
"49": 4622615552.0,
"50": 4622615552.0
}
},
"iteration-time": {
"start_step": 1,
"end_step": 50,
"step_interval": 1,
"values": {
"1": 12.785,
"2": 0.28429,
"3": 0.25654,
"4": 0.25675,
"5": 0.25763,
"6": 0.25556,
"7": 0.25403,
"8": 0.25276,
"9": 0.25351,
"10": 0.25546,
"11": 0.25488,
"12": 0.25607,
"13": 0.25404,
"14": 0.25256,
"15": 0.25733,
"16": 0.25987,
"17": 0.25778,
"18": 0.25053,
"19": 0.25288,
"20": 0.258,
"21": 0.25606,
"22": 0.25231,
"23": 0.25223,
"24": 0.26464,
"25": 0.26469,
"26": 0.25015,
"27": 0.25378,
"28": 0.25459,
"29": 0.26134,
"30": 0.26129,
"31": 0.2595,
"32": 0.26444,
"33": 0.25568,
"34": 0.25514,
"35": 0.25087,
"36": 0.25275,
"37": 0.25383,
"38": 0.24953,
"39": 0.24996,
"40": 0.25393,
"41": 0.25556,
"42": 0.25158,
"43": 0.25124,
"44": 0.25,
"45": 0.25586,
"46": 0.26057,
"47": 0.25868,
"48": 0.26304,
"49": 0.2615,
"50": 0.26261
"1": 13.74796,
"2": 0.16361,
"3": 0.12487,
"4": 0.11772,
"5": 0.11849,
"6": 0.11989,
"7": 0.11765,
"8": 0.11845,
"9": 0.11909,
"10": 0.11808,
"11": 0.11972,
"12": 0.12,
"13": 0.11843,
"14": 0.11918,
"15": 0.11921,
"16": 0.11744,
"17": 0.11954,
"18": 0.11987,
"19": 0.12032,
"20": 0.11887,
"21": 0.16664,
"22": 0.14091,
"23": 0.11946,
"24": 0.11878,
"25": 0.12175,
"26": 0.16637,
"27": 0.12057,
"28": 0.11963,
"29": 0.11766,
"30": 0.11771,
"31": 0.11891,
"32": 0.11873,
"33": 0.12109,
"34": 0.12022,
"35": 0.11979,
"36": 0.12012,
"37": 0.11942,
"38": 0.12115,
"39": 0.1194,
"40": 0.12047,
"41": 0.12028,
"42": 0.12169,
"43": 0.12404,
"44": 0.12402,
"45": 0.12356,
"46": 0.12029,
"47": 0.11637,
"48": 0.11959,
"49": 0.11817,
"50": 0.12162
}
}
}
Loading
Loading