support qwen2 and siglip weight conversion script to enable training … #1221
+44
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with llava-next and llava-onevision
jon-barker
reviewed
Oct 17, 2024
| @@ -60,8 +60,9 @@ def __init__( | |||
| self.img_h = img_h | |||
| self.img_w = img_w | |||
|
|
|||
| assert self.img_h % self.patch_dim == 0 | |||
| assert self.img_w % self.patch_dim == 0 | |||
| if model_subtype == "siglip": | |||
There was a problem hiding this comment.
Why are we moving this assert so it's only used in the siglip case? We want it for the base clip case don't we?
There was a problem hiding this comment.
We are moving this assert to be used only in the siglip case because the model used in siglip does not satisfy this assert, while the models used in several clip cases do satisfy it. By the way, do we have any specific reason for adding this assert before? If there is no other special reason, we can consider removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…with llava-next and llava-onevision