Add warp select predicate to TMA store's FenceAsyncProxy#4820
Draft
jacobhinkle wants to merge 1 commit intomainfrom
Draft
Add warp select predicate to TMA store's FenceAsyncProxy#4820jacobhinkle wants to merge 1 commit intomainfrom
jacobhinkle wants to merge 1 commit intomainfrom
Conversation
Description
Changes walkthrough 📝
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Collaborator
Author
|
!test |
This was referenced Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR:
After this PR:
This predicate suffices for warp specialized TMA store in Hopper matmul. I have not yet checked the TMA store use cases in normalization.
Timing of
MLPBenchmarkTest.FwdGEMM/persistent_warpspec:That example has a large main loop (80 stages)
Timing of
HopperMatmulTest.PingPongPersistent:Here we see a measurable difference. The main advantage of this PR is that it enables #4804 and #4810 which will bring larger speedups.
Fixes #4813