Skip to content

Conversation

@xwang233
Copy link
Collaborator

per title

@xwang233 xwang233 requested a review from jjsjann123 April 29, 2025 21:01
@github-actions
Copy link

github-actions bot commented Apr 29, 2025

Review updated until commit 501dab8

Description

  • Updated README to reflect torch 2.7 builds

  • Corrected typos and formatting in README

  • Updated nightly installation instructions


Changes walkthrough 📝

Relevant files
Enhancement
README.md
Update README for torch 2.7 and formatting                             

README.md

  • Updated build matrix to include torch 2.7
  • Removed cuda 12.4 from build matrix
  • Corrected typos in nightly installation instructions
  • Added note about latest stable builds
  • +22/-10 

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🧪 No relevant tests
    ⚡ Recommended focus areas for review

    Typo

    There is a typo in the installation command for the nightly nvfuser pip package. The command should be pip install --pre nvfuser-cu128 --extra-index-url https://pypi.nvidia.com instead of pip install --pre nvfuser-cu121 --extra-index-url https://pypi.nvidia.com.

    You can install a nightly nvfuser pip package built against torch nightly code base with
    Typo

    There is a typo in the description of the optional dependency for the nightly torch wheel. The text should be "optional dependency" instead of "optinoal dependency".

    we have explicitly marked the nightly torch wheel as an optional dependency.
    Outdated CUDA Version

    The CUDA version cuda 12.4 is not listed in the new release matrix. Ensure that all relevant CUDA versions are included.

    built-env | cuda 11.8 | cuda12.6 | cuda 12.8

    @xwang233
    Copy link
    Collaborator Author

    !build

    Copy link
    Collaborator

    @jjsjann123 jjsjann123 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @xwang233 xwang233 merged commit 54a94d8 into main Apr 30, 2025
    16 checks passed
    @xwang233 xwang233 deleted the update-readme-torch27 branch April 30, 2025 20:42
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants