You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR renames getRawLoad to getRawAsync in ParallelDimensionMap. Recently, CircularBufferLoopStage changed LoadWarp to AsyncWarp. This function corresponds with LoadWarp and needs to be updated accordingly.
The implementation of getRawAsync seems to be incorrect. It returns a padded value when warp specialization is enabled, which is different from the behavior of the old getRawLoad method. This change might lead to incorrect behavior in the code.
The documentation for getRawAsync does not match its implementation. The comment suggests that the method returns a padded value for warp specialization, but the implementation returns a padded value regardless of warp specialization.
//! of without warp specialization, this is the same as getRaw(pt). For warp//! warp specialization on pt, the result is padded_value. The last part of//! pt is used for AsyncWarp warp group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames
getRawLoadtogetRawAsyncinParallelDimensionMap. Recently,CircularBufferLoopStagechangedLoadWarptoAsyncWarp. This function corresponds withLoadWarpand needs to be updated accordingly.