-
Notifications
You must be signed in to change notification settings - Fork 84
Litgpt benchmark #4320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Litgpt benchmark #4320
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
41ac781
adding litgpt benchmark
jjsjann123 1e5812b
fixing script
jjsjann123 ec729b2
Merge remote-tracking branch 'origin/main' into litgpt_benchmark
jjsjann123 04d4144
adding iobytes computation
jjsjann123 228cf5c
fixing iobytes
jjsjann123 e6447a2
populate the benchmark with the rest of litgpt model configs
jjsjann123 f987def
configs
jjsjann123 7936055
typo
jjsjann123 51cd064
adding resize marker
jjsjann123 9134cc3
removing requirements
jjsjann123 ab2b495
Merge remote-tracking branch 'origin/main' into litgpt_benchmark
jjsjann123 592d011
Merge remote-tracking branch 'origin/main' into litgpt_benchmark
jjsjann123 183b4f9
fixing import in cross_entropy_loss
jjsjann123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| litgpt[all] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this requirement local?
We have several benchmark files that can run okay without this module. So this can be a hassle when trying to run unrelated benchmarks.
One way could be to use
@pytest.mark.skipifto check for the presence of this module in relevant benchmarks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fair. I guess I should have stick to what the other benchmarks are doing and rely on the module installed in the container. At least we do have litgpt in our CI containers. I'll remove this file.