Skip to content

fix(release): pass Helm version to registration - #991

Merged
svvarom merged 2 commits into
mainfrom
fix-helm-release-version-contract/svvarom
Jul 30, 2026
Merged

fix(release): pass Helm version to registration#991
svvarom merged 2 commits into
mainfrom
fix-helm-release-version-contract/svvarom

Conversation

@svvarom

@svvarom svvarom commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Forward the already-resolved Helm chart version in the stable release-registration payload whenever Helm is selected.

Why

A stable Helm-only release can use SemVer build metadata for a chart correction while retaining the application release version. The registration consumer needs the exact chart version instead of assuming both versions are identical.

Non-Helm releases and all existing build, staging, polling, and deployment behavior remain unchanged.

Validation

  • actionlint .github/workflows/release.yaml
  • git diff --check

Rollout

Merge after the registration consumer accepts the optional helm_version field.

Summary by CodeRabbit

  • Improvements
    • Release registration now includes the Helm version when Helm artifacts are part of a release.
    • Improved release metadata accuracy for Helm-based releases.

Signed-off-by: Swarom Muley <smuley@nvidia.com>
@github-actions github-actions Bot added the fix label Jul 30, 2026
@svvarom svvarom self-assigned this Jul 30, 2026
@svvarom
svvarom marked this pull request as ready for review July 30, 2026 17:12
@svvarom
svvarom requested a review from a team as a code owner July 30, 2026 17:12
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 457fbf00-9ef8-4792-beef-82646902be89

📥 Commits

Reviewing files that changed from the base of the PR and between ffa3c98 and 8064200.

📒 Files selected for processing (1)
  • .github/workflows/release.yaml

📝 Walkthrough

Walkthrough

The release workflow now passes the resolved Helm version into the register-release-artifacts dispatch payload when Helm is included.

Changes

Release registration

Layer / File(s) Summary
Add Helm version to dispatch payload
.github/workflows/release.yaml
The registration dispatch step adds HELM_VERSION to its environment and conditionally includes helm_version alongside helm_id.

Possibly related PRs

Suggested labels: ci

Suggested reviewers: crookedstorm, mckornfield

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: passing the Helm version to release registration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-helm-release-version-contract/svvarom

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 28288/36121 78.3% 62.7%
Integration Tests 16874/34839 48.4% 21.0%

@svvarom
svvarom enabled auto-merge July 30, 2026 18:24
@svvarom
svvarom added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit 7d03ce4 Jul 30, 2026
57 of 58 checks passed
@svvarom
svvarom deleted the fix-helm-release-version-contract/svvarom branch July 30, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants