Skip to content

test(deployments): keep the image pull out of the observe-wait timing window #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SandyChapman wants to merge 1 commit into from
Closed

test(deployments): keep the image pull out of the observe-wait timing window #989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions plugins/nemo-deployments/tests/integration/backends/docker/test_docker_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,14 @@ def _docker_backend_with_observe_timeout(
*,
oneshot_observe_timeout_seconds: int,
) -> DockerDeploymentBackend:
return _build_docker_backend(oneshot_observe_timeout_seconds=oneshot_observe_timeout_seconds)
# `pull_images` is off so the caller can pre-pull and keep the registry
# round-trip out of any window it times. `create_deployment` pulls
# unconditionally, not just when the image is missing locally, so leaving
# this on would put ~2s of Docker Hub latency inside the measurement.
return _build_docker_backend(
oneshot_observe_timeout_seconds=oneshot_observe_timeout_seconds,
pull_images=False,
)


def _always_http_config() -> DeploymentConfig:
Expand Down Expand Up @@ -169,8 +176,9 @@ async def test_never_deployment_outlives_observe_wait_then_succeeds() -> None:
client = docker.from_env()

try:
# Warm the image cache so the timed window below measures the observe wait
# rather than an uncached image pull.
# The backend is built with `pull_images=False`, so this pull is what puts
# the image on the host. Doing it here keeps it out of the timed window
# below, which is measuring the observe wait.
await asyncio.to_thread(client.images.pull, ALPINE_IMAGE)

started = time.monotonic()
Expand Down
Loading