-
Notifications
You must be signed in to change notification settings - Fork 21
feat(agents): support agents plugin CLI extensions #960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e3080e0
feat(agents): support plugin CLI extensions
cursoragent d2ce361
fix(plugin): sort discovery test imports
cursoragent 21bb07d
chore(cli): refresh vendored agent commands
cursoragent e12ab2c
refactor(agents): simplify CLI extension contract
cursoragent 5fbbb19
style(agents): format CLI registration
cursoragent f4095ba
fix(agents): isolate failing CLI extensions
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from unittest.mock import patch | ||
|
|
||
| import typer | ||
| from nemo_agents_plugin.cli import AgentsCLI | ||
| from nemo_platform_plugin.cli import NemoCLI | ||
| from typer.testing import CliRunner | ||
|
|
||
|
|
||
| class _AnalystCLI(NemoCLI): | ||
| name = "analyst" | ||
|
|
||
| def get_cli(self) -> typer.Typer: | ||
| app = typer.Typer(help="Analyst agent commands.") | ||
|
|
||
| @app.callback() | ||
| def _root() -> None: | ||
| """Force subcommand dispatch.""" | ||
|
|
||
| @app.command() | ||
| def run() -> None: | ||
| typer.echo("analysis complete") | ||
|
|
||
| return app | ||
|
|
||
|
|
||
| def test_plugin_can_contribute_agent_cli() -> None: | ||
| with patch("nemo_agents_plugin.cli.discover_agent_cli", return_value={"analyst": _AnalystCLI}): | ||
| app = AgentsCLI().get_cli() | ||
|
|
||
| result = CliRunner().invoke(app, ["analyst", "run"]) | ||
|
|
||
| assert result.exit_code == 0, result.stderr | ||
| assert result.stdout.strip() == "analysis complete" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.