test(intake): pin ClickHouse 26.3 LTS

[BrianNewsom]

Summary

• bind Intake local development and integration tests to the ClickHouse 26.3 LTS line
• reject reuse of a local ClickHouse container running a different image
• verify the integration server remains on 26.3 and document the supported baseline

Validation

• ruff check and ruff format --check
• ty check on changed Python files
• ClickHouse bootstrap integration tests: 3 passed on the 26.3 image tag

Summary by CodeRabbit

• Bug Fixes

  • Updated Intake’s supported ClickHouse version to 26.3 LTS.
  • Added validation to detect mismatched ClickHouse container images before startup.

• Tests

  • Integration test coverage now verifies the running ClickHouse server matches the supported LTS version.
  • Test ClickHouse Docker image selection is now driven by the repository’s pinned version.

• Documentation

  • Clarified ClickHouse 26.3 LTS support and compatibility expectations for local development.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2d0a9bf1-4fa8-405c-bb20-4ca6810536e2

📥 Commits

Reviewing files that changed from the base of the PR and between 0454f7a and 8523cc8.

📒 Files selected for processing (6)

• services/intake/.clickhouse-version
• services/intake/README.md
• services/intake/scripts/spans/run_clickhouse.sh
• services/intake/src/nmp/intake/spans/evaluation_session_repository.py
• services/intake/tests/integration/spans/conftest.py
• services/intake/tests/integration/spans/test_clickhouse_bootstrap.py

🚧 Files skipped from review as they are similar to previous changes (6)

• services/intake/.clickhouse-version
• services/intake/README.md
• services/intake/tests/integration/spans/test_clickhouse_bootstrap.py
• services/intake/scripts/spans/run_clickhouse.sh
• services/intake/src/nmp/intake/spans/evaluation_session_repository.py
• services/intake/tests/integration/spans/conftest.py

---

📝 Walkthrough

Walkthrough

ClickHouse is pinned to 26.3, propagated to local tooling and integration fixtures, documented as the supported LTS version, and validated for existing containers and server responses. Query comments now describe CTE behavior without version-specific wording.

Changes

ClickHouse version alignment

Layer / File(s)	Summary
Version contract and container enforcement services/intake/.clickhouse-version, services/intake/README.md, services/intake/scripts/spans/run_clickhouse.sh, services/intake/src/nmp/intake/spans/evaluation_session_repository.py	ClickHouse is pinned and documented as 26.3 LTS; the container script derives its image tag from the pin and rejects mismatched existing containers. Query comments use version-neutral CTE wording.
Integration version validation services/intake/tests/integration/spans/conftest.py, services/intake/tests/integration/spans/test_clickhouse_bootstrap.py	Fixtures read the shared version pin, use it for container setup, expose it to tests, and verify SELECT version() returns the expected prefix.

Possibly related PRs

• NVIDIA-NeMo/nemo-platform#893: Modifies the same ClickHouse container startup paths with container reuse handling.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: pinning Intake to ClickHouse 26.3 LTS.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch clickhouse-dao-characterization/brnewsom

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

services/intake/tests/integration/spans/test_clickhouse_bootstrap.py (1)

14-18: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add a concrete type hint for run_async.

The new test types the other parameters but leaves this fixture untyped. Use the repository’s concrete callable type, such as Callable[[Any], Any], and import it normally.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@services/intake/tests/integration/spans/test_clickhouse_bootstrap.py` around
lines 14 - 18, Add a concrete callable type annotation to the run_async
parameter in test_clickhouse_server_matches_supported_lts, using the
repository’s established Callable[[Any], Any] form. Add the required Callable
and Any imports normally without changing the test behavior.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@services/intake/README.md`:
- Around line 63-64: Move the ClickHouse compatibility requirement from its
current position below run_clickhouse.sh to the prerequisites section near the
Docker prerequisite above the startup command. Keep the existing wording and
ensure users see the supported ClickHouse version before setup instructions.

---

Nitpick comments:
In `@services/intake/tests/integration/spans/test_clickhouse_bootstrap.py`:
- Around line 14-18: Add a concrete callable type annotation to the run_async
parameter in test_clickhouse_server_matches_supported_lts, using the
repository’s established Callable[[Any], Any] form. Add the required Callable
and Any imports normally without changing the test behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 88fd0241-0fd5-4623-b66f-c533cb6717cf

📥 Commits

Reviewing files that changed from the base of the PR and between ee4dfd8 and 0454f7a.

📒 Files selected for processing (6)

• services/intake/.clickhouse-version
• services/intake/README.md
• services/intake/scripts/spans/run_clickhouse.sh
• services/intake/src/nmp/intake/spans/evaluation_session_repository.py
• services/intake/tests/integration/spans/conftest.py
• services/intake/tests/integration/spans/test_clickhouse_bootstrap.py

[github-actions]

Suite	Lines Covered	Line Rate	Branch Rate
Unit Tests	27292/35040	77.9%	62.1%
Integration Tests	16025/33752	47.5%	19.9%