fix: make Insight evaluation promotion-safe - #907
Merged
ryana merged 1 commit intoJul 27, 2026
Merged
Conversation
Reissues NVIDIA-dev/NeMo-Optimizer#97 for the Experimentalist plugin.\n\nLinear: ASE-684, ASE-699 Signed-off-by: Ryan Angilly <rangilly@nvidia.com>
ryana
merged commit Jul 27, 2026
1800292
into
ase-625-insight-suite-promotion/rangilly
4 checks passed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nemo-experimentalist-insight-suite://artifact schemeStack
This is layer 4 of 4 and must merge after:
The base branch is
ase-625-insight-suite-promotion/rangilly, so this PR displays only its incremental correctness and safety diff.Provenance
Validation
uv run --frozen --group experimentalist pytest -q plugins/nemo-experimentalist/tests— 563 passed, 2 skippeduv run --frozen ruff check plugins/nemo-experimentalist— passeduv run --frozen ruff format --check plugins/nemo-experimentalist— passedty checkpassed for every changed Python fileSKIP=studio-lint-staged uv run pre-commit run -a— all applicable hooks passedThe two skipped tests are existing opt-in checks that require external credentials/runtime. The Studio hook was skipped because this stack is Python-only and the local Studio toolchain is unavailable (Node 22.14 is below the repository's 22.18 minimum, and pnpm is not installed).