fix(nemo-agents): update fabric adapter compatibility - #865
Merged
Conversation
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
Signed-off-by: Manjesh Mogallapalli <mmogallapall@nvidia.com>
Contributor
📝 WalkthroughWalkthroughUpdates Fabric dependency packaging, changes Codex adapter translation, adds Hermes Python environment configuration, documents the example workflow, updates tests, and refreshes third-party advisory and license metadata. ChangesFabric adapter integration
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
plugins/nemo-agents/examples/nemo-agent-config/README.md (1)
1-42: 📐 Maintainability & Code Quality | 🟠 Major | 🏗️ Heavy liftRestructure this as a complete HOW-TO page.
Add prerequisites at the top; present Codex and Hermes as tabbed variants; provide both Python SDK and CLI examples; verify the snippets before publishing; add
Next Stepscross-links; and use configured substitutions for product names in prose.As per coding guidelines, documentation pages must list prerequisites first, fit one Diataxis quadrant, use tab sets for variants, provide Python SDK and CLI examples, include Next Steps, test snippets, and avoid hardcoded product names.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/nemo-agents/examples/nemo-agent-config/README.md` around lines 1 - 42, Restructure the README into a complete HOW-TO page: add prerequisites first, use configured substitutions for product names in prose, and place Codex and Hermes instructions in tabbed variants. Provide verified Python SDK and CLI examples for each applicable variant, then add a Next Steps section with cross-links to related documentation; keep all commands and configuration consistent with the existing agent.yaml workflow.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/nemo-agents/examples/nemo-agent-config/README.md`:
- Around line 35-41: Update the Hermes workflow instructions in the README to
explicitly restore default_harness to codex in agent.yaml after the Hermes
invocation, so subsequent invocations use the standard Codex default.
In `@plugins/nemo-agents/pyproject.toml`:
- Around line 21-23: The nemo-fabric dependency pins are inconsistent with the
lockfile. Update the pins at plugins/nemo-agents/pyproject.toml lines 21-23 and
packages/nemo_platform/pyproject.toml lines 237-239 for nemo-fabric[runtime],
nemo-fabric-adapters-codex, and nemo-fabric-adapters-hermes to 0.1.0a20260722,
or regenerate the lockfile so all dependency declarations and the lock resolve
to the same versions.
In `@plugins/nemo-agents/tests/unit/test_fabric_translator.py`:
- Around line 74-85: Update
test_repository_example_uses_current_codex_and_isolated_hermes_adapters to
assert config.default_harness equals "codex", then call
translate_agent_config(config) without harness_name for the Codex translation;
keep the explicit Hermes translation and existing adapter/settings assertions
unchanged.
---
Outside diff comments:
In `@plugins/nemo-agents/examples/nemo-agent-config/README.md`:
- Around line 1-42: Restructure the README into a complete HOW-TO page: add
prerequisites first, use configured substitutions for product names in prose,
and place Codex and Hermes instructions in tabbed variants. Provide verified
Python SDK and CLI examples for each applicable variant, then add a Next Steps
section with cross-links to related documentation; keep all commands and
configuration consistent with the existing agent.yaml workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f608b1b7-1f2a-4fba-8487-0a847f19eef6
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (12)
packages/nemo_platform/pyproject.tomlplugins/nemo-agents/examples/nemo-agent-config/.gitignoreplugins/nemo-agents/examples/nemo-agent-config/README.mdplugins/nemo-agents/examples/nemo-agent-config/agent.yamlplugins/nemo-agents/pyproject.tomlplugins/nemo-agents/src/nemo_agents_plugin/fabric/translator.pyplugins/nemo-agents/tests/unit/test_agent_config.pyplugins/nemo-agents/tests/unit/test_fabric_translator.pyplugins/nemo-agents/tests/unit/test_fabric_validation.pythird_party/licenses.jsonlthird_party/osv-licenses.jsonthird_party/requirements-main.txt
Contributor
|
Signed-off-by: Manjesh Mogallapalli <mmogallapall@nvidia.com>
AjayThorve
approved these changes
Jul 23, 2026
Signed-off-by: Manjesh Mogallapalli <mmogallapall@nvidia.com>
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the NeMo Agents Fabric integration to align with the current
nemo-fabric>=0.1.0a20260724,<0.2.0packaging/API shape while keeping Fabric out of the default Platform dependency path for now.The main intent is to keep the default workspace and CI compatible while still allowing Fabric-backed agent flows to be tested explicitly via the
nemo-agents-plugin[fabric]extra.Changes
fabricextra onnemo-agents-plugin.nemo-agents-plugindependency bundle inpackages/nemo_platform.nemo-fabric[runtime]>=0.1.0a20260724,<0.2.0nemo-fabric-adapters-codex>=0.1.0a20260724,<0.2.0nemo-fabric-adapters-hermes>=0.1.0a20260724,<0.2.0nvidia.fabric.codex.clitonvidia.fabric.codex.HERMES_ADAPTER_PYTHON.Why Fabric Is Optional For Now
nemo-fabric>=0.1.0a20260724,<0.2.0uses the newer config-first SDK contract. Other workspace consumers are still migrating to that contract, so installing Fabric in the default workspace can cause unrelated type/lint failures.Keeping Fabric behind
nemo-agents-plugin[fabric]lets us test and iterate on the NeMo Agents Fabric path without forcing the whole workspace onto that SDK API immediately.Summary by CodeRabbit
Summary
python_envsetting.artifacts/,workspace/).