Skip to content

test(evaluator): Keep Evaluator mock VirtualModels out of orphan cleanup #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JashG wants to merge 1 commit into from
Closed

test(evaluator): Keep Evaluator mock VirtualModels out of orphan cleanup #833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions e2e/test_evaluator_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ def _add_mock_provider_or_skip(
workspace=workspace,
name=name,
mock_response_body=mock_response_body,
# Keep test VMs out of controller orphan cleanup between readiness wait and job scoring.
should_autoprovision_virtual_model=False,
)
except RuntimeError as exc:
if "mock_provider_prefix is not configured" in str(exc):
Expand Down Expand Up @@ -258,8 +260,20 @@ def _create_ready_mock_model(
model_providers=[f"{workspace}/{provider.name}"],
exist_ok=True,
)
wait_for_model_entity(sdk, workspace, name, ensure_virtual_model=True)
ensure_passthrough_virtual_model(sdk, workspace, name, timeout=IGW_ROUTE_TIMEOUT_SECONDS)
wait_for_model_entity(
sdk,
workspace,
name,
ensure_virtual_model=True,
should_autoprovision_virtual_model=False,
)
ensure_passthrough_virtual_model(
sdk,
workspace,
name,
timeout=IGW_ROUTE_TIMEOUT_SECONDS,
autoprovisioned=False,
)
_wait_for_stable_model_chat_route(sdk, workspace, name)


Expand Down