fix(guardrails): Propagate mutated text to proxied request/response - #813
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughInput rails now propagate transformed user content into sanitized upstream requests without mutating originals. Output rails rewrite assistant content in returned responses while preserving upstream data and handling non-string message content. ChangesRail masking propagation
Sequence Diagram(s)sequenceDiagram
participant Client
participant process_request
participant apply_input_rail_modifications
participant UpstreamModel
participant build_output_response_body
Client->>process_request: Request with messages
process_request->>apply_input_rail_modifications: Input-rail GenerationResponse
apply_input_rail_modifications-->>process_request: Copied messages with modified user content
process_request->>UpstreamModel: Sanitized request with updated messages
UpstreamModel-->>build_output_response_body: Upstream response
build_output_response_body-->>Client: Response with masked assistant content
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
gabwow
left a comment
There was a problem hiding this comment.
thanks, one additional optional nit.
Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com>
Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com>
Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com>
8a2034a to
f1834aa
Compare
…813) * fix(guardrails): Propagate mutated text to proxied request/response Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com> * Minor fix Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com> * remove redundant resolver Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com> * Remove redundant param in test helper Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com> * fix lint Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com> --------- Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com> Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>
Summary
choices[0].message.content.request.bodyin place (sanitize + messages replace) instead of reconstructingInferenceRequest, so fields liketyped_bodyare preserved; IGW re-derivestyped_bodyafter the plugin.Summary by CodeRabbit
role=usermessage content when text-only.