fix(studio): Docs for Data Designer - #790
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughAdded Data Designer documentation and Studio navigation, plus generated-file checks that isolate newly introduced changes from pre-existing diffs. ChangesData Designer documentation
Generated-file synchronization checks
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Signed-off-by: Sean Teramae <steramae@nvidia.com>
b024a47 to
5b32fe8
Compare
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/scripts/src/check-generated-files.ts`:
- Around line 11-12: Update the before/after snapshots in the generated-file
check around execAsync and beforeFiles to use path-only output from the same
repository reference, such as git diff --name-only HEAD, so staged changes and
status metadata do not produce false new-file reports. Apply the same snapshot
logic to the corresponding after-state handling, and include untracked files if
pnpm gen can create them.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b2c8fb35-e639-41ec-b76c-4a1985eb41c1
📒 Files selected for processing (1)
web/packages/scripts/src/check-generated-files.ts
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae steramae@nvidia.com
Summary by CodeRabbit