chore: enable volume extra test - #754
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughE2E Kubernetes job profiles now mount a PVC-backed volume at ChangesE2E job storage
Safe Synthesizer fileset setup
Evaluator mock-model provisioning
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
* Also fix nss test Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
b254027 to
bb75b8f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@e2e/k8s/values/minikube.yaml`:
- Line 40: Update the volume_permissions_image entry in the Minikube values
configuration to define it under core.storage, matching the path used by the
other values files and the configured core.volumePermissionsImage value. Ensure
the resulting Helm values structure applies the configured volume permissions
image for this profile.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 515de610-9706-457b-888b-4c943d6598dc
📒 Files selected for processing (7)
e2e/k8s/values/default.yamle2e/k8s/values/kind.yamle2e/k8s/values/minikube-auth-portforward.yamle2e/k8s/values/minikube-auth.yamle2e/k8s/values/minikube.yamle2e/test_jobs.pye2e/test_safe_synthesizer.py
🚧 Files skipped from review as they are similar to previous changes (2)
- e2e/test_jobs.py
- e2e/test_safe_synthesizer.py
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
* chore: enable volume extra test * Also fix nss test Signed-off-by: Matt Kornfield <mkornfield@nvidia.com> * chore: attempt to fix a flake in eval test Signed-off-by: Matt Kornfield <mkornfield@nvidia.com> --------- Signed-off-by: Matt Kornfield <mkornfield@nvidia.com> Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>
Summary by CodeRabbit
/mnt/additional_storage.additional-volumeCPU executor profile across the E2E inference gateway and minikube/kind environments./mnt/additional_storagemount is available.