Skip to content

fix(studio): Fix RadioCard interactions - #730

Merged
htolentino-nvidia merged 3 commits into
mainfrom
studio-fix-radio-card/htolentino
Jul 22, 2026
Merged

fix(studio): Fix RadioCard interactions#730
htolentino-nvidia merged 3 commits into
mainfrom
studio-fix-radio-card/htolentino

Conversation

@htolentino-nvidia

@htolentino-nvidia htolentino-nvidia commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Currently Radio Card inputs require a precise click on the radio input area instead of the whole card (like it originally worked)

Summary by CodeRabbit

  • Style
    • Improved radio card styling so selected and disabled states are displayed more consistently.
    • Updated interaction and visual feedback for radio cards without changing their user-facing behavior.

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
@htolentino-nvidia
htolentino-nvidia requested review from a team as code owners July 16, 2026 17:33
@github-actions github-actions Bot added the fix label Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

RadioCard now uses a grouped RadioGroupItem wrapper without asChild; the nested Card responds to checked and disabled states through group-data selectors.

Changes

RadioCard group state styling

Layer / File(s) Summary
Group state styling
web/packages/common/src/components/RadioCard/index.tsx
RadioGroupItem adds group block, while Card checked and disabled styles use group-data selectors.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the RadioCard interaction fix and the code changes that adjust click/checked styling behavior.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch studio-fix-radio-card/htolentino

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@web/packages/common/src/components/RadioCard/index.tsx`:
- Around line 87-88: Update the RadioGroupItem props in the RadioCard component
so attributes?.RadioGroupItem.className is merged with the required "group block
w-full items-start" classes rather than overriding them. Preserve all other
caller-provided RadioGroupItem attributes while ensuring group remains present
for group-data-* styling.
- Around line 87-96: Update the RadioGroupItem wrapper in the RadioCard
component so the fixed className containing group is not overridden by
attributes?.RadioGroupItem. Move the spread before className or merge the
supplied and fixed classes, preserving caller attributes while ensuring
group-data-* styles continue to work.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 451f566b-b560-4f7e-bc32-a9f30f97d3d2

📥 Commits

Reviewing files that changed from the base of the PR and between a7e7c21 and 2b626dc.

📒 Files selected for processing (1)
  • web/packages/common/src/components/RadioCard/index.tsx

Comment thread web/packages/common/src/components/RadioCard/index.tsx Outdated
Comment thread web/packages/common/src/components/RadioCard/index.tsx Outdated
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 27114/34832 77.8% 62.1%
Integration Tests 15891/33443 47.5% 19.9%

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
@htolentino-nvidia htolentino-nvidia changed the title fix(studio): Fix RadioCard clicks fix(studio): Fix RadioCard interactions Jul 16, 2026
@htolentino-nvidia
htolentino-nvidia added this pull request to the merge queue Jul 22, 2026
Merged via the queue into main with commit aad544c Jul 22, 2026
58 checks passed
@htolentino-nvidia
htolentino-nvidia deleted the studio-fix-radio-card/htolentino branch July 22, 2026 14:41
soluwalana pushed a commit that referenced this pull request Jul 22, 2026
* Fix RadioCard clicks

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>

* Small fixes

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>

---------

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants