fix(studio): Fix RadioCard interactions - #730
Merged
Merged
Conversation
Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
Contributor
📝 WalkthroughWalkthroughRadioCard now uses a grouped ChangesRadioCard group state styling
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/common/src/components/RadioCard/index.tsx`:
- Around line 87-88: Update the RadioGroupItem props in the RadioCard component
so attributes?.RadioGroupItem.className is merged with the required "group block
w-full items-start" classes rather than overriding them. Preserve all other
caller-provided RadioGroupItem attributes while ensuring group remains present
for group-data-* styling.
- Around line 87-96: Update the RadioGroupItem wrapper in the RadioCard
component so the fixed className containing group is not overridden by
attributes?.RadioGroupItem. Move the spread before className or merge the
supplied and fixed classes, preserving caller attributes while ensuring
group-data-* styles continue to work.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 451f566b-b560-4f7e-bc32-a9f30f97d3d2
📒 Files selected for processing (1)
web/packages/common/src/components/RadioCard/index.tsx
Contributor
|
Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
steramae-nvidia
approved these changes
Jul 16, 2026
htolentino-nvidia
enabled auto-merge
July 22, 2026 14:13
soluwalana
pushed a commit
that referenced
this pull request
Jul 22, 2026
* Fix RadioCard clicks Signed-off-by: Henrique Tolentino <htolentino@nvidia.com> * Small fixes Signed-off-by: Henrique Tolentino <htolentino@nvidia.com> --------- Signed-off-by: Henrique Tolentino <htolentino@nvidia.com> Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Radio Card inputs require a precise click on the radio input area instead of the whole card (like it originally worked)
Summary by CodeRabbit