chore: address k8s docs wording - #719
Merged
Merged
Conversation
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Contributor
|
🌿 Preview your docs: https://nvidia-preview-helm-docs-pr-review-mck.docs.buildwithfern.com/nemo-platform |
Contributor
📝 WalkthroughWalkthroughUpdated CLI and documentation wording for Kubernetes deployment guidance and EFA networking references. No runtime behavior or public declarations changed. ChangesDocumentation guidance
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/cli/reference.mdx`:
- Line 10: Update the source text that generates the Kubernetes deployment guide
wording, then run make generate-cli-reference-docs to regenerate
docs/cli/reference.mdx. Do not hand-edit the generated reference file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4c44ef8b-f85f-4b8f-8358-21c5e5a2d307
⛔ Files ignored due to path filters (1)
sdk/python/nemo-platform/src/nemo_platform/cli/app.pyis excluded by!sdk/**
📒 Files selected for processing (3)
docs/cli/reference.mdxdocs/set-up/helm/install.mdxpackages/nemo_platform_ext/src/nemo_platform_ext/cli/app.py
Contributor
|
soluwalana
pushed a commit
that referenced
this pull request
Jul 17, 2026
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit