Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ repos:
hooks:
- id: studio-typecheck
name: Run UI typecheck
entry: bash -c '[ -n "$CI" ] && exit 0; command -v pnpm >/dev/null 2>&1 || { echo "pnpm not installed, skipping typecheck (see web/README.md for setup)"; exit 0; }; cd web && pnpm --filter="...[origin/main]" run --parallel --if-present typecheck:go'
entry: bash -c '[ -n "$CI" ] && exit 0; command -v pnpm >/dev/null 2>&1 || { echo "pnpm not installed, skipping typecheck (see web/README.md for setup)"; exit 0; }; cd web && pnpm --filter="...[origin/main]" run --parallel --if-present typecheck'
Comment thread
coderabbitai[bot] marked this conversation as resolved.
language: system
files: ^web/
pass_filenames: false
Expand Down
1 change: 1 addition & 0 deletions web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"lint-staged": "^16.4.0",
"prettier": "^3.6.2",
"tsx": "catalog:",
"typescript": "npm:@typescript/typescript6@6.0.2",
"typescript-eslint": "^8.59.0"
},
"engines": {
Expand Down
4 changes: 1 addition & 3 deletions web/packages/common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
"test:ci": "vitest run --coverage",
"test:watch": "vitest watch",
"test:once": "vitest --run",
"typecheck": "tsc --noEmit",
"typecheck:go": "tsgo --noEmit"
"typecheck": "tsc --noEmit"
},
"peerDependencies": {
"@nemo/sdk": "workspace:*",
Expand Down Expand Up @@ -50,7 +49,6 @@
"@types/papaparse": "^5.3.16",
"@types/react": "catalog:",
"@types/react-dom": "catalog:",
"@typescript/native-preview": "catalog:",
"@vitejs/plugin-react": "catalog:",
"@vitest/coverage-v8": "catalog:",
"happy-dom": "catalog:",
Expand Down
2 changes: 0 additions & 2 deletions web/packages/scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,11 @@
"lint": "eslint . --max-warnings 0",
"lint:fix": "eslint . --fix",
"typecheck": "tsc --noEmit --noErrorTruncation",
"typecheck:go": "tsgo --noEmit --noErrorTruncation",
"sortEnv": "tsx ./src/sortEnv.ts "
},
"devDependencies": {
"@types/node": "catalog:",
"@types/yargs": "^17.0.33",
"@typescript/native-preview": "catalog:",
"knip": "^6.6.2",
"prettier": "^3.2.5",
"typescript": "catalog:",
Expand Down
2 changes: 0 additions & 2 deletions web/packages/studio/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
"test:e2e:record": "RECORD=1 playwright test --grep @record",
"test:ci": "NODE_OPTIONS=--max-old-space-size=10240 CI=true vitest --run --coverage --reporter=junit --reporter=default",
"typecheck": "tsc --noEmit --noErrorTruncation",
"typecheck:go": "tsgo --noEmit --noErrorTruncation",
"bundle-visualize": "pnpm exec vite-bundle-visualizer -c vite.config.ts",
"update-warning-count": "pnpm tsx ../common/scripts/update-max-warnings.ts",
"screenshots": "tsx screenshots/capture.ts",
Expand Down Expand Up @@ -111,7 +110,6 @@
"@types/react": "catalog:",
"@types/react-dom": "catalog:",
"@types/seedrandom": "^3.0.8",
"@typescript/native-preview": "catalog:",
"@vitest/coverage-v8": "catalog:",
"@vitest/ui": "catalog:",
"blob-polyfill": "^9.0.20240710",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe('spanKeyValues', () => {
...span!,
usage_details: {},
cost_details: {},
evaluation_context: { metadata: {} },
evaluation_context: {},
},
{ workspace: 'default' }
);
Expand Down
11 changes: 2 additions & 9 deletions web/packages/studio/src/util/intakeTelemetry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,18 +76,11 @@ export const getEvaluationContextSummary = (
context: SpanEvaluationContext | null | undefined
): string => {
if (!context) return EMPTY_VALUE;
return context.evaluation_run_id || context.evaluation_id || context.test_case_id || EMPTY_VALUE;
return context.evaluation_id || context.test_case_id || EMPTY_VALUE;
};

export const hasEvaluationContext = (context: SpanEvaluationContext | null | undefined): boolean =>
Boolean(
context &&
(context.evaluation_id ||
context.evaluation_sha ||
context.evaluation_run_id ||
context.test_case_id ||
(context.metadata && Object.keys(context.metadata).length > 0))
);
Boolean(context && (context.evaluation_id || context.test_case_id));

export const compareSpansByStartedAt = (a: Span, b: Span): number => {
const aStartedAt = Date.parse(a.started_at);
Expand Down
4 changes: 1 addition & 3 deletions web/packages/testing/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
"private": true,
"type": "module",
"scripts": {
"typecheck": "tsc --noEmit",
"typecheck:go": "tsgo --noEmit"
"typecheck": "tsc --noEmit"
},
"exports": {
"./*": "./src/*.ts"
Expand All @@ -15,7 +14,6 @@
"@testing-library/jest-dom": "catalog:",
"@testing-library/react": "catalog:",
"@types/react-dom": "catalog:",
"@typescript/native-preview": "catalog:",
"happy-dom": "catalog:",
"typescript": "catalog:",
"vitest": "catalog:",
Expand Down
871 changes: 536 additions & 335 deletions web/pnpm-lock.yaml

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions web/pnpm-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ catalog:
'@types/react': ^19.2.5
'@types/react-dom': ^19.2.3
'@types/qs': ^6.14.0
'@typescript/native-preview': 7.0.0-dev.20251124.1
'@vitejs/plugin-react': ^6.0.2
'@vitejs/plugin-react-swc': ^3.11.0
'@vitest/coverage-v8': 4.1.9
Expand Down Expand Up @@ -57,7 +56,7 @@ catalog:
storybook: ^10.4.6
tailwindcss: ^4.1.11
tsx: ^4.22.4
typescript: ^6.0.0
typescript: ~7.0.0
use-debounce: ^10.0.6
vite: ^8.0.16
vite-plugin-mkcert: ^1.17.8
Expand Down