Skip to content

ci: wire the real release deployment signal #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svvarom merged 2 commits into from
Jul 14, 2026
Merged

ci: wire the real release deployment signal #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3081fdf
ci: wire release deployment signal
svvarom Jul 14, 2026
db32d44
fix(ci): allow nightly deployment signal
svvarom Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,10 +751,12 @@ jobs:
helm cm-push "${CHART_PACKAGE}" nemo-platform
fi

dispatch-release-deployment:
name: Dispatch release deployment
signal-deployment:
name: Signal deployment
needs: [plan-release, stage-helm, poll-final-release]
if: >-
!cancelled() &&
needs.poll-final-release.result == 'success' &&
needs.plan-release.outputs.include_helm == 'true' &&
needs.plan-release.outputs.dry_run != 'true'
runs-on: ubuntu-latest
Expand Down Expand Up @@ -1049,16 +1051,6 @@ jobs:
--generate-notes \
"${notes_range[@]}"

signal-deployment:
name: Signal deployment
needs: [plan-release, poll-final-release]
if: >-
needs.poll-final-release.result == 'success' &&
needs.plan-release.outputs.dry_run != 'true'
runs-on: ubuntu-latest
steps:
- run: echo "::notice::Placeholder - signal the completed release"

notify-end:
name: Notify release result
needs:
Expand Down
8 changes: 4 additions & 4 deletions RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,10 @@ America/Los_Angeles.
GitHub release and tag at the selected SHA. GitHub generates the release
notes from the previous numeric SemVer tag. Subset releases do not create a
GitHub release or tag.

The deployment-signalling job is currently a placeholder. A successful poll
means the selected artifacts are public; it does not yet mean a deployment was
created by this workflow.
8. After polling succeeds, releases that include the Helm chart dispatch a
deployment signal to the configured internal release repository. The
downstream workflow creates a pending GitHub Deployment, and the deployment
controller completes it independently. Releases without Helm skip this step.

## Publication destinations

Expand Down