Skip to content

ci: correct the blank SHA case for releases #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crookedstorm merged 1 commit into from
Jul 13, 2026
Merged

ci: correct the blank SHA case for releases #660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,12 @@ on:
type: string
default: ""
include-helm:
description: "Include the Helm chart in a custom release."
description: "Include the Helm chart if defining a strict list of release artifacts instead of the default (release everything)."
required: false
type: boolean
default: false
update-ngc-metadata:
description: "Synchronize NGC metadata from the default branch."
description: "Synchronize NGC metadata from the this branch."
Comment thread
crookedstorm marked this conversation as resolved.
required: false
type: boolean
default: false
Expand Down Expand Up @@ -174,8 +174,8 @@ jobs:
const sendNotifications = inputs["send-notifications"] !== "false";
const dryRun = isManual && inputs["dry-run"] === "true";

let sourceSha = isManual ? inputs["source-sha"].trim() : context.sha;
const version = releaseType === "stable" ? inputs.version.trim() : "";
let sourceSha = isManual ? (inputs["source-sha"] ?? "").trim() : context.sha;
const version = releaseType === "stable" ? (inputs.version ?? "").trim() : "";

if (releaseType === "stable") {
if (!/^[0-9a-f]{40}$/i.test(sourceSha)) {
Expand Down Expand Up @@ -307,6 +307,12 @@ jobs:
fetch-tags: true
persist-credentials: false

- name: Ensure selected source is an ancestor of this workflow revision
shell: bash
env:
SOURCE_SHA: ${{ steps.plan.outputs.source_sha }}
run: git merge-base --is-ancestor "${SOURCE_SHA}" "${GITHUB_SHA}"

- name: Validate selected release artifacts
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
env:
Expand Down