Skip to content

feat(deployments): k8s PodSpec compiler for full workload config (AIRCORE-757 phase 5) #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tylersbray merged 3 commits into from
Jul 2, 2026
Merged

feat(deployments): k8s PodSpec compiler for full workload config (AIRCORE-757 phase 5) #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf57df4
feat(deployments): add k8s PodSpec compiler for full workload config …
tylersbray Jul 2, 2026
150e27f
fix(deployments): address CodeRabbit review on phase 5 PodSpec compiler
tylersbray Jul 2, 2026
0e34d63
fix(deployments): address mckornfield review on phase 5 compiler
tylersbray Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions plugins/nemo-deployments/openapi/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class K8sDeploymentBackend(DeploymentBackend):
"""Manage deployments and volumes as native Kubernetes objects.

Job-backed deployments (``restart_policy`` Never/OnFailure) are implemented in phase 3.
Deployment + Service (Always) is implemented in phase 4; full PodSpec compilation lands in phase 5.
Deployment + Service (Always) is implemented in phase 4; full PodSpec compilation is phase 5.
"""

_clients: KubernetesClients
Expand Down Expand Up @@ -146,7 +146,7 @@ async def read_status(self, *, workspace: str, name: str) -> BackendStatusUpdate

if config.restart_policy == "Always":
try:
container = deployment_ops.validate_config_for_deployment(config)
deployment_ops.validate_config_for_deployment(config)
except job_ops.DeploymentConfigError as exc:
return BackendStatusUpdate(status="FAILED", status_message=str(exc))
return await deployment_ops.read_deployment_status(
Expand All @@ -158,7 +158,7 @@ async def read_status(self, *, workspace: str, name: str) -> BackendStatusUpdate
config_name=config.name,
restart_policy=config.restart_policy,
backoff_limit=config.backoff_limit,
container=container,
containers=tuple(config.containers),
)

return await job_ops.read_job_status(
Expand Down
Loading