fix(e2e): fix local minikube scripts and switch CLI health checks to /status

[matthewgrossman]

Summary

Two fixes:

1. CLI and e2e health checks: /health/ready → /status

The nemo CLI (services start, setup, quickstart) and e2e test harness were polling /health/ready to check if the platform is up. This endpoint is not exposed through ingress — by design, /health is for K8s pod probes, not external access. Switched to /status, which is already in the ingress allowlist and returns richer application-level health info.

Changed files: CLI source (packages/nemo_platform_ext/.../quickstart/cli.py, services/cli.py, setup.py), vendored SDK copies, e2e/conftest.py, e2e/k8s/scripts/run_auth_e2e.sh

2. Fix local_build_and_upgrade.sh

The script was broken in several ways:

• Referenced nonexistent e2e/k8s/values/local.yaml
• Didn't set api.image.repository or pullPolicy — pods tried to pull from nvcr.io instead of using local images
• Used the GPU setup script (no port mapping) — localhost:30080 didn't work
• Duplicated Helm install logic from install_helm_e2e.sh

Now delegates to install_helm_e2e.sh for the Helm install, uses the CPU setup script with port mapping, and supports configurable registry via NMP_REGISTRY env var. Also added NMP_E2E_PULL_POLICY to install_helm_e2e.sh so local builds can set pullPolicy=Never.

Test plan

• minikube delete → bash e2e/k8s/scripts/local_build_and_upgrade.sh succeeds end-to-end
• curl localhost:30080/status returns 200
• Full e2e suite against minikube: 54 passed, 2 failed (pre-existing), 8 skipped

Closes AIRCORE-786
Closes AIRCORE-791

🤖 Generated with Claude Code

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds NMP_E2E_PULL_POLICY support to install_helm_e2e.sh for overriding image pull policies. Rewrites local_build_and_upgrade.sh to use profile-scoped minikube startup, configurable registry, and delegates Helm install to install_helm_e2e.sh via exec. Replaces all /health/ready readiness probe endpoints with /status across CLI commands and E2E scripts.

Changes

Helm Pull Policy Override and Local Build Delegation

Layer / File(s)	Summary
NMP_E2E_PULL_POLICY in install_helm_e2e.sh e2e/k8s/scripts/install_helm_e2e.sh	Declares NMP_E2E_PULL_POLICY variable (empty default) and conditionally appends --set api.image.pullPolicy and --set core.image.pullPolicy to HELM_ARGS.
Profile-aware build and exec delegation e2e/k8s/scripts/local_build_and_upgrade.sh	Adds MINIKUBE_PROFILE-scoped startup via setup_local_minikube_cpu.sh, epoch-based IMAGE_TAG, NMP_REGISTRY-driven docker buildx bake docker-cpu, and replaces the direct helm upgrade --install call with exec install_helm_e2e.sh passing NMP_E2E_PULL_POLICY=Never.

Readiness Probe Endpoint Change to /status

Layer / File(s)	Summary
/health/ready → /status everywhere e2e/conftest.py, e2e/k8s/scripts/run_auth_e2e.sh, packages/nemo_platform_ext/src/nemo_platform_ext/cli/commands/quickstart/cli.py, .../services/cli.py, .../setup.py	All readiness poll targets switch from /health/ready to /status, with matching docstring/error-message updates.

Suggested labels

ci

Suggested reviewers

• svvarom

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: fixing local minikube scripts and switching health checks from /health/ready to /status.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch mgrossman/aircore-786-local-docker-image-build-story-is-broken-for-nemo-platform

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Suite	Lines Covered	Line Rate	Branch Rate
Unit Tests	21176/27762	76.3%	61.2%
Integration Tests	12216/26531	46.0%	19.5%

[mckornfield]

some minor things

[mckornfield]

some minor things

[crookedstorm]

Looks good to me, for what it's worth.

[github-actions]

🌿 Preview your docs: https://nvidia-preview-mgrossman-aircore-786-local-docker-image-build.docs.buildwithfern.com/nemo-platform