-
Notifications
You must be signed in to change notification settings - Fork 18
chore(guardrails): speed up IGW middleware integration test fixtures #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
albcui
merged 5 commits into
main
from
albcui/AIRCORE-585/speed-up-igw-middleware-integration-test-fixtures-by-module-scoping
May 27, 2026
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8f3d7c5
chore(guardrails): module-scope IGW + Models ASGI test stack
albcui 77877b0
Thread workspace pass-thru across all helpers
albcui 6ec4111
Simplify docstrings and comments
albcui 0abd460
Address CodeRabbit's concerns
albcui b87d7cd
address comments
albcui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,22 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Pytest fixture re-export for the example plugin integration tests. | ||
| """Pytest fixture re-exports for the example plugin integration tests. | ||
|
|
||
| Re-exporting :func:`igw_plugin_harness` from a project-level ``conftest.py`` | ||
| is the standard pytest pattern for sharing a fixture across a test package | ||
| without importing it at the top of every test module. Listing it in | ||
| ``__all__`` makes the re-export explicit so it isn't flagged as an unused | ||
| import. | ||
| The module-scope helpers (``_igw_app_context``, ``_igw_extra_services``) | ||
| are re-imported so pytest can resolve :func:`igw_plugin_harness`'s | ||
| dependency chain. The default empty ``_igw_extra_services`` tuple | ||
| applies — no services beyond IGW + Models are mounted. | ||
| """ | ||
|
|
||
| from nmp.core.inference_gateway.testing.fixtures import igw_plugin_harness | ||
| from nmp.core.inference_gateway.testing.fixtures import ( | ||
| _igw_app_context, | ||
| _igw_extra_services, | ||
| igw_plugin_harness, | ||
| ) | ||
|
|
||
| __all__ = ["igw_plugin_harness"] | ||
| __all__ = [ | ||
| "_igw_app_context", | ||
| "_igw_extra_services", | ||
| "igw_plugin_harness", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.