Skip to content

fix(studio): use singular agent_name/agent_version in experiments views - #311

Closed
marcusds wants to merge 1 commit into
mainfrom
astd-244-fix-experiment-agent-name-singular/mschwab
Closed

fix(studio): use singular agent_name/agent_version in experiments views#311
marcusds wants to merge 1 commit into
mainfrom
astd-244-fix-experiment-agent-name-singular/mschwab

Conversation

@marcusds

@marcusds marcusds commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the 3 TS2551 errors that have made the Studio typecheck check red on main:

  • ExperimentGroupDataView/index.tsx:127,133agent_names / agent_versions not on ExperimentRow
  • ExperimentDetailRoute/ExperimentDetailMetrics.tsx:31agent_names not on ExperimentResponse

Root cause: #294 (d5165414bd, "Roll up agent_names/agent_versions") left these views reading plural agent_names/agent_versions as arrays (.join(', ')), but the generated SDK type ExperimentResponse exposes singular agent_name: string / agent_version: string (one agent per experiment). The plural fields never existed in the TS SDK, so typecheck has been broken since that commit.

Changes

  • ExperimentGroupDataView: agent_names/agent_versions columns → singular agent_name/agent_version accessors; headers "Agent Name"/"Agent Version".
  • ExperimentDetailMetrics: agent_names?.join(', ')agent_name; label "Agent Name".

Testing

  • Full studio typecheck: 0 errors (was 3)
  • eslint clean; no remaining agent_names/agent_versions references in studio; no specs cover these files

Resolves ASTD-244.

Summary by CodeRabbit

  • Refactor
    • Simplified agent information display in experiment tables and detail views to show a single agent name and version instead of multiple joined values.
    • Updated metric labels to reflect the single-value format.
    • Added "-" placeholder for missing agent information.
    • Disabled sorting on agent information columns.

ExperimentGroupDataView and ExperimentDetailMetrics read plural
agent_names/agent_versions as arrays (.join), but the generated SDK type
ExperimentResponse exposes singular agent_name/agent_version (one agent per
experiment). The plural fields never existed in the TS SDK, so studio typecheck
has been red since #294 (d516541). Read the singular fields directly.

ASTD-244

Signed-off-by: mschwab <mschwab@nvidia.com>
@marcusds
marcusds requested review from a team as code owners June 12, 2026 18:15
@github-actions github-actions Bot added the fix label Jun 12, 2026
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7534a779-594d-4351-9073-e54f10a6e656

📥 Commits

Reviewing files that changed from the base of the PR and between 313e80b and b349a13.

📒 Files selected for processing (2)
  • web/packages/studio/src/components/dataViews/ExperimentGroupDataView/index.tsx
  • web/packages/studio/src/routes/ExperimentDetailRoute/ExperimentDetailMetrics.tsx

📝 Walkthrough

Walkthrough

Experiment UI displays agent information via single-value fields instead of comma-joined arrays. Table columns for agent_name and agent_version render individual values or - with sorting disabled. Detail metrics KVPair switches from "Agent Names" (joined) to "Agent Name" (single value).

Changes

Agent Field Display Updates

Layer / File(s) Summary
Single-value agent field display in experiment views
web/packages/studio/src/components/dataViews/ExperimentGroupDataView/index.tsx, web/packages/studio/src/routes/ExperimentDetailRoute/ExperimentDetailMetrics.tsx
Table columns and detail metrics render agent_name and agent_version as single values (or - when missing), with sorting disabled on the table columns.

Possibly related PRs

  • NVIDIA-NeMo/nemo-platform#260: Updates to ExperimentDetailMetrics.tsx for new Experiment Detail page that directly overlaps with this PR's metrics display change.
  • NVIDIA-NeMo/nemo-platform#229: Updates to ExperimentGroupDataView and agent column rendering align with this PR's switch from multi-value to single-value agent fields.

Suggested labels

fix

Suggested reviewers

  • nakolean
  • walston
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: switching from plural to singular agent field names in experiment views.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch astd-244-fix-experiment-agent-name-singular/mschwab

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 19033/25227 75.4% 61.3%
Integration Tests 11028/23999 46.0% 20.4%

@marcusds

Copy link
Copy Markdown
Contributor Author

Closing: misdiagnosis on my part. web/packages/sdk/generated is git-ignored/generated; my local copy was stale (singular agent_name), so a local typecheck showed false errors. The real spec/SDK exposes plural agent_names/agent_versions (string[]), so #294 and main were always correct and green on CI. This PR's singular change is the actual regression. No fix needed.

@marcusds marcusds closed this Jun 12, 2026
@marcusds
marcusds deleted the astd-244-fix-experiment-agent-name-singular/mschwab branch June 12, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant