fix(guardrails): update jailbreak-detect model deployment to match ne… - #287
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughServer model discovery now resolves MODEL_ID from env vars and derives owned_by from that namespace; tests cover resolver and /v1/models output. README replaces the file-based deployment config with an inline nemo CLI command and expands IGW + guardrails end-to-end wiring and testing steps. ChangesJailbreak Detect Combined Changes
Sequence Diagram(s)Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
services/jailbreak-detect/README.md (1)
6-266: 🏗️ Heavy liftSplit this README into one Diataxis quadrant.
It mixes explanation, how-to, and reference content, and it still lacks the required prerequisites-at-top / Next Steps framing. Keep this page as a short entry point with cross-links, and move the walkthroughs into separate docs. As per coding guidelines, each documentation page should fit ONE Diataxis quadrant, list prerequisites first, and include a Next Steps section at the end.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@services/jailbreak-detect/README.md` around lines 6 - 266, README.md currently mixes Diataxis quadrants; split it into a short entrypoint README (keep the top-level description, HTTP contract, prerequisites-first, and add a "Next Steps" with cross-links) and move procedural/how-to content into separate focused docs (e.g., a "Local development (uv)" quickstart, "Build the image" & "Deploy via Models + Inference Gateway" how-to, "Wire it end-to-end with a chat model" walkthrough, and an "Evaluating the model" / "Tests" reference), update links in the entry README to point to those new pages, and ensure references to model/server.py and scripts/eval.py remain accurate (mention they live in the repo) so readers can find the runnable examples.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@services/jailbreak-detect/README.md`:
- Around line 6-266: README.md currently mixes Diataxis quadrants; split it into
a short entrypoint README (keep the top-level description, HTTP contract,
prerequisites-first, and add a "Next Steps" with cross-links) and move
procedural/how-to content into separate focused docs (e.g., a "Local development
(uv)" quickstart, "Build the image" & "Deploy via Models + Inference Gateway"
how-to, "Wire it end-to-end with a chat model" walkthrough, and an "Evaluating
the model" / "Tests" reference), update links in the entry README to point to
those new pages, and ensure references to model/server.py and scripts/eval.py
remain accurate (mention they live in the repo) so readers can find the runnable
examples.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5e271197-d504-4f02-9647-8cd4ba3b189e
📒 Files selected for processing (2)
services/jailbreak-detect/README.mdservices/jailbreak-detect/deploy/deployment-config.json
💤 Files with no reviewable changes (1)
- services/jailbreak-detect/deploy/deployment-config.json
…w schema Signed-off-by: Albert Cui <albcui@nvidia.com>
Signed-off-by: Albert Cui <albcui@nvidia.com>
Signed-off-by: Albert Cui <albcui@nvidia.com>
fef9209 to
70ece41
Compare
Signed-off-by: Albert Cui <albcui@nvidia.com>
…w schema
Summary by CodeRabbit