Skip to content

ci(studio): add SDK gen check for OpenAPI spec changes (ASTD-218) #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusds merged 5 commits into from
Jun 10, 2026
Merged

ci(studio): add SDK gen check for OpenAPI spec changes (ASTD-218) #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
296f021
ci(studio): add SDK gen check for OpenAPI spec changes (ASTD-218)
marcusds Jun 9, 2026
bd5bb6f
ci(studio): typecheck SDK generated output directly (ASTD-218)
marcusds Jun 9, 2026
8527917
ci(studio): drop studio typecheck from web-sdk-gen job (ASTD-218)
marcusds Jun 9, 2026
8ac4cb1
fix(ci): update config-reference-docs hook to .mdx extension (ASTD-218)
marcusds Jun 10, 2026
eeb2c21
fix(ci): add web-sdk-gen to ci-status required checks (ASTD-218)
marcusds Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/changes/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ runs:
filters: |
openapi:
- 'openapi/**'
- 'plugins/*/openapi/**'
tests:
- 'tests/**'
- 'pytest.ini'
Expand Down
29 changes: 29 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,34 @@ jobs:
- name: Lint
run: pnpm lint

web-sdk-gen:
name: Web SDK generation check
needs: [changes]
if: >
!cancelled() && (
github.event_name == 'workflow_dispatch' ||
needs.changes.outputs.openapi == 'true' ||
needs.changes.outputs.web-studio == 'true'
)
runs-on: ubuntu-latest
defaults:
run:
working-directory: web
shell: bash
steps:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: "22"
- name: Install pnpm via corepack
run: npm i -g corepack@0.31.0 && corepack enable pnpm
- name: Install dependencies
run: pnpm install --frozen-lockfile
- name: Generate SDK from OpenAPI specs
run: pnpm --filter @nemo/sdk gen:all-force
- name: Typecheck SDK generated output
run: pnpm --filter @nemo/sdk typecheck

Comment thread
coderabbitai[bot] marked this conversation as resolved.
web-studio-deps:
name: Web studio deps check
needs: [changes]
Expand Down Expand Up @@ -740,6 +768,7 @@ jobs:
- web-test
- web-format
- web-lint
- web-sdk-gen
- web-studio-deps
- web-studio-e2e
- benchmark-guardrails
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@ repos:
hooks:
- id: config-reference-docs
name: Check config reference doc is up to date
entry: bash -c 'uv run generate-config-docs && git diff --exit-code docs/set-up/config-reference.md'
entry: bash -c 'uv run generate-config-docs && git diff --exit-code docs/set-up/config-reference.mdx'
language: system
pass_filenames: false
files: |
(?x)^(
script/generate_config_docs\.py|
packages/nmp_common/.*|
services/.*/src/.*/config\.py|
docs/set-up/config-reference\.md
docs/set-up/config-reference\.mdx
)$

- repo: https://github.com/norwoodj/helm-docs
Expand Down
Loading