Skip to content

fix: set HF_TOKEN during integration and unit tests - #202

Merged
mckornfield merged 1 commit into
mainfrom
fix-hf-token-missing/mck
Jun 5, 2026
Merged

fix: set HF_TOKEN during integration and unit tests#202
mckornfield merged 1 commit into
mainfrom
fix-hf-token-missing/mck

Conversation

@mckornfield

@mckornfield mckornfield commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Release Notes

This release contains no user-facing changes. Updates were made to internal CI/CD configuration to enhance the build and test pipeline infrastructure.

@mckornfield
mckornfield requested a review from a team as a code owner June 5, 2026 15:55
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
@mckornfield
mckornfield force-pushed the fix-hf-token-missing/mck branch from fff97b5 to 9b2994e Compare June 5, 2026 15:55
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: dfd64e04-5c81-4f02-9618-bba0c024c0b6

📥 Commits

Reviewing files that changed from the base of the PR and between 20cd98c and 9b2994e.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml

📝 Walkthrough

Walkthrough

The CI workflow adds the HF_TOKEN secret to environment variables in both the python-unit-test and python-integration-test job environment blocks, enabling tests to access the Hugging Face token during execution.

Changes

CI Environment Configuration

Layer / File(s) Summary
HF_TOKEN injection into test jobs
.github/workflows/ci.yaml
HF_TOKEN: ${{ secrets.HF_TOKEN }} added to environment blocks for both unit test (line 145) and integration test (line 193) jobs.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding HF_TOKEN to integration and unit test environments.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-hf-token-missing/mck

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 18714/24765 75.6% 62.0%
Integration Tests 11995/23529 51.0% 26.2%

@mckornfield
mckornfield added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit 68441f4 Jun 5, 2026
33 checks passed
lbliii added a commit that referenced this pull request Jun 5, 2026
main brought #201 (NemoGuard casing), #202 (HF_TOKEN in tests), and #192
(studio filter debounce). Only one conflict:

- docs/run-inference/tutorials/deploy-models.md (modify/delete): this page
  is gated (migrated to .mdx, out of the nav). Port main's NemoGuard casing
  fix into docs/run-inference/tutorials/deploy-models.mdx (NeMo Guard
  Jailbreak Detection -> NemoGuard JailbreakDetect; NeMoGuard -> NemoGuard)
  to keep the gated page maintained, and keep the legacy .md deleted.

The studio/test changes auto-merged with no docs impact. Verified: no
conflict markers, validate-mdx 194 files clean, gated-link check clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants