-
Notifications
You must be signed in to change notification settings - Fork 20
feat(eval-author): default Author clients to medium reasoning effort #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a64d51e
c4f15a9
49eb435
f464765
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,7 +38,41 @@ The preset includes the run inputs needed by `run_eval_author(...)`: | |
| - `task_template`: local or `fileset://` evaluator task template URI for production traces. | ||
| - `experiment_dir`: local Eval Author working directory. | ||
| - `workspace`, `base_url`, `mode`, and `evaluator_type`: platform and evaluator routing. | ||
| - `eval_author.max_summary_tokens` and `eval_author.max_traces`: agent tuning parameters. | ||
| - `eval_author.*`: agent tuning — see below. | ||
|
|
||
| ### `EvalAuthorConfig` (model and completion options) | ||
|
|
||
| **Use `reasoning_effort` of `medium` or higher** (`high`, and any stronger | ||
| provider value your model accepts). Below `medium` — including `minimal`, | ||
| `low`, `none`, or omitting the field so the provider picks a weak default — | ||
| Eval Author often authors flat, non-discriminating metrics that look fine on a | ||
| broken baseline. The default is `"medium"` for that reason. Prefer raising | ||
| effort over lowering it when Author quality is inconsistent. | ||
|
|
||
| | Field | Default | Meaning | | ||
| | --- | --- | --- | | ||
| | `max_summary_tokens` | `80000` | Token budget for the fast-model summarizer. | | ||
| | `max_traces` | `10` | Insight `trace_refs` to analyze in depth. | | ||
| | `max_validation_repair_attempts` | `5` | Repair attempts after Insight verifier validation fails. | | ||
| | `reasoning_effort` | `"medium"` | OpenAI-shaped effort for Author clients. Keep at `medium` or higher for consistent metric authoring; do not set `null` / `minimal` / `low` unless you are deliberately testing failure modes. | | ||
| | `completion_params` | `{}` | Extra kwargs forwarded to `CompletionClient` (non-OpenAI backends or other OpenAI knobs). An explicit `reasoning_effort` wins over the same key here. | | ||
|
|
||
| Standalone `run_eval_author(...)` builds clients with these options. In | ||
| Experimentalist Insight mode, the runner nested-resolves Author-scoped clients | ||
| from the run config's `eval_author` block (same defaults), then restores the | ||
| outer Experimentalist default/fast pair for the optimization loop. | ||
|
|
||
| Example override in Experimentalist `--config` YAML: | ||
|
|
||
| ```yaml | ||
| eval_author: | ||
| max_traces: 5 | ||
| reasoning_effort: medium # required floor for consistent Author metrics; use high if needed | ||
| # completion_params: | ||
| # thinking: | ||
| # type: enabled | ||
| # budget_tokens: 2048 | ||
| ``` | ||
|
Comment on lines
+43
to
+75
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win Separate the reference from the override procedure. Lines 45-51 are reference content. Lines 58-68 are how-to content. Move the YAML override procedure to a how-to page and cross-link it from this reference section. As per coding guidelines, “Each documentation page should fit ONE Diataxis quadrant; do not mix tutorials with reference tables or how-tos with architecture explanations; use cross-links instead.” 🤖 Prompt for AI AgentsSource: Coding guidelines |
||
|
|
||
| ## Materialized Insight Suite | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,3 +29,4 @@ optimizer: | |
| eval_author: | ||
| max_traces: 10 | ||
| max_validation_repair_attempts: 5 | ||
| reasoning_effort: medium | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,3 +27,4 @@ optimizer: | |
| eval_author: | ||
| max_traces: 3 | ||
| max_validation_repair_attempts: 2 | ||
| reasoning_effort: medium | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,3 +23,4 @@ optimizer: | |
| eval_author: | ||
| max_traces: 10 | ||
| max_validation_repair_attempts: 5 | ||
| reasoning_effort: medium | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,3 +24,4 @@ optimizer: | |
| eval_author: | ||
| max_traces: 3 | ||
| max_validation_repair_attempts: 2 | ||
| reasoning_effort: medium | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,3 +19,4 @@ outcome_evaluator_config: | |
| eval_author: | ||
| max_traces: 3 | ||
| max_validation_repair_attempts: 2 | ||
| reasoning_effort: medium | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Honor
reasoning_effort: nullwhen parameters conflict.reasoning_effort=Nonepromises to omit the field. Line 106 retainscompletion_params["reasoning_effort"], so a merged config still sends it. Remove that key whenreasoning_effortisNone. Add a regression test for this conflict.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents