chore(skills): sync outdated skill - #131
Merged
Merged
Conversation
Contributor
|
Contributor
|
/nvskills-ci |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughSmall docs and metadata updates: clarified SKILL.md Output Template guidance, revised skill-card and benchmark docs (dates/scores/metadata), and replaced the sigstore DSSE payload in skill.oms.sig. ChangesDocs & Metadata Updates
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
/nvskills-ci |
Signed-off-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Signed-off-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Signed-off-by: Nick Goncharenko <ngoncharenko@nvidia.com>
ngoncharenko
force-pushed
the
ngoncharenko/aalgo-231-sync-sig
branch
from
June 2, 2026 21:40
39a833e to
3bc01a9
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
skills/nemo-data-designer-plugin/skill-card.md (1)
12-12: ⚡ Quick winUse Sphinx substitution for product name.
Hardcoded product naming in the use-case text conflicts with the docs rule for substitutions.
Proposed fix
-Developers and engineers who need to create synthetic datasets, generate data, or build data generation pipelines using the NeMo Data Designer library. <br> +Developers and engineers who need to create synthetic datasets, generate data, or build data generation pipelines using the |product_name| library. <br>As per coding guidelines, "Never hardcode product names; use substitutions in Sphinx configuration to maintain consistency across documentation."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/nemo-data-designer-plugin/skill-card.md` at line 12, Replace the hardcoded product name "NeMo Data Designer" in the sentence "Developers and engineers who need to create synthetic datasets, generate data, or build data generation pipelines using the NeMo Data Designer library." with the Sphinx substitution token (e.g. |product_name|) and ensure the corresponding substitution is defined in the Sphinx config (rst_prolog or substitutions file); update the string in skill-card.md to use the substitution token and confirm the substitution key matches the one used across docs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/nemo-data-designer-plugin/skill-card.md`:
- Around line 73-74: The markdown heading "## Skill Version(s):" in
skill-card.md needs a blank line after it to satisfy MD022; update the content
around the "## Skill Version(s):" heading so there's an empty line between the
heading and the following text "0.1.0 (source: pyproject.toml)".
- Line 32: The skill output guidance was changed to "Python script with PEP 723
inline metadata" but the evaluator (evals/evals.json) still expects a script
defining load_config_builder(), so revert or update the guidance to include that
function: modify the Output Format in skill-card.md to require a Python script
containing the PEP 723 inline metadata plus a load_config_builder() function
(exact name load_config_builder) that returns the expected builder
object/structure; ensure the instruction text explicitly names
load_config_builder() so outputs align with the evaluator and avoid expectation
drift.
---
Nitpick comments:
In `@skills/nemo-data-designer-plugin/skill-card.md`:
- Line 12: Replace the hardcoded product name "NeMo Data Designer" in the
sentence "Developers and engineers who need to create synthetic datasets,
generate data, or build data generation pipelines using the NeMo Data Designer
library." with the Sphinx substitution token (e.g. |product_name|) and ensure
the corresponding substitution is defined in the Sphinx config (rst_prolog or
substitutions file); update the string in skill-card.md to use the substitution
token and confirm the substitution key matches the one used across docs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4478ccc7-94f1-466e-b057-125e2ce5b6e7
📒 Files selected for processing (4)
skills/nemo-data-designer-plugin/BENCHMARK.mdskills/nemo-data-designer-plugin/SKILL.mdskills/nemo-data-designer-plugin/skill-card.mdskills/nemo-data-designer-plugin/skill.oms.sig
✅ Files skipped from review due to trivial changes (2)
- skills/nemo-data-designer-plugin/BENCHMARK.md
- skills/nemo-data-designer-plugin/SKILL.md
🚧 Files skipped from review as they are similar to previous changes (1)
- skills/nemo-data-designer-plugin/skill.oms.sig
Contributor
|
/nvskills-ci |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
skills/nemo-data-designer-plugin/skill-card.md (1)
30-32:⚠️ Potential issue | 🟠 Major | ⚡ Quick winOutput format still doesn't mention
load_config_builder().Past review flagged that evaluators expect
load_config_builder()in Output Format, but it only appears in Other Properties. Move the function requirement to line 30 or clarify the evaluator expectation.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/nemo-data-designer-plugin/skill-card.md` around lines 30 - 32, The Output Format currently omits the required load_config_builder() mention; update the Output Format line (the one that reads "Python script with PEP 723 inline metadata") to explicitly state that the generated Python file must include a load_config_builder() function returning a DataDesignerConfigBuilder, or alternatively clarify in Output Format that evaluators will look for load_config_builder() (reference symbols: load_config_builder and DataDesignerConfigBuilder) so the requirement is not only in Other Properties.
🧹 Nitpick comments (1)
skills/nemo-data-designer-plugin/skill-card.md (1)
28-28: 💤 Low valueAdd blank lines after headings (MD022).
Lines 28, 34, 40 need blank lines after headings per markdownlint.
Also applies to: 34-34, 40-40
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/nemo-data-designer-plugin/skill-card.md` at line 28, The markdown headings (e.g., the "## Skill Output:" heading in skill-card.md and the other headings at the referenced locations) are missing a blank line after the heading which violates MD022; add a single blank line immediately after each heading (the "## Skill Output:" heading and the other two headings referenced) so each heading is followed by an empty line before the next content.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@skills/nemo-data-designer-plugin/skill-card.md`:
- Around line 30-32: The Output Format currently omits the required
load_config_builder() mention; update the Output Format line (the one that reads
"Python script with PEP 723 inline metadata") to explicitly state that the
generated Python file must include a load_config_builder() function returning a
DataDesignerConfigBuilder, or alternatively clarify in Output Format that
evaluators will look for load_config_builder() (reference symbols:
load_config_builder and DataDesignerConfigBuilder) so the requirement is not
only in Other Properties.
---
Nitpick comments:
In `@skills/nemo-data-designer-plugin/skill-card.md`:
- Line 28: The markdown headings (e.g., the "## Skill Output:" heading in
skill-card.md and the other headings at the referenced locations) are missing a
blank line after the heading which violates MD022; add a single blank line
immediately after each heading (the "## Skill Output:" heading and the other two
headings referenced) so each heading is followed by an empty line before the
next content.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1fbe5dc8-413d-42ec-9080-3bce7450f8a4
📒 Files selected for processing (3)
skills/nemo-data-designer-plugin/BENCHMARK.mdskills/nemo-data-designer-plugin/skill-card.mdskills/nemo-data-designer-plugin/skill.oms.sig
ngoncharenko
enabled auto-merge
June 2, 2026 23:18
gabwow
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No file changes.
This PR contains a signed empty commit so the NVSkills pipeline can be triggered for the synced signature branch and skill revalidation.
Summary by CodeRabbit