fix: correct third-party license inventory - #1281
Closed
mckornfield wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
mckornfield
commented
Aug 13, 2026
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
mckornfield
marked this pull request as ready for review
August 13, 2026 16:11
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request updates SPDX license expressions for seven dependencies in the license override configuration and recorded license inventory. All affected entries remain marked compatible. ChangesLicense metadata
Suggested reviewers: Mergeability Score: ⚪ Minimal · up to This change corrects reviewed third-party license metadata and the generated inventory without altering runtime behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
ironcommit
approved these changes
Aug 13, 2026
Contributor
Author
|
covered by #1266 |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the published third-party license inventory so the checked-in JSONL matches the reviewed license data for the packages called out by OSRB review. The stale bare LGPL/MIT entries are replaced with the reviewed MPL, UPL, LGPL exception, and composite license expressions.
Changes
tools/nemo-platform-sdk-tools/src/nemo_platform_sdk_tools/license/overrides.yamlwith reviewed license data for certifi, pathspec, psycopg2-binary, tqdm, langchain-oci, greenlet, and regex.third_party/licenses.jsonlfrom the updated override data.Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
PYTHONPATH=tools/nemo-platform-sdk-tools/src uv run --no-project --with pyyaml --with requests --with packaging --with typer --with rich python - <<'PY' ... format_licenses(...) ... PY— regeneratedthird_party/licenses.jsonlfrom checked-in OSV data and updated overrides.jq -r 'select(.name|IN("certifi","pathspec","psycopg2-binary","tqdm","langchain-oci","greenlet","regex")) | @json' third_party/licenses.jsonl— verified corrected rows for all reviewed packages.jq -r 'select(.license == "LGPL") | @json' third_party/licenses.jsonl— no output; no bare LGPL rows remain.PYTHONPATH=tools/nemo-platform-sdk-tools/src uv run --no-project --with pyyaml --with requests --with packaging --with typer --with rich python - <<'PY' ... find_missing_licenses() ... PY— passed; total packages needing overrides: 0.PYTHONPATH=tools/nemo-platform-sdk-tools/src uv run --no-project --with pyyaml python - <<'PY' ... yaml.safe_load(overrides.yaml) ... PY— passed; loaded 190 overrides.git diff --check origin/main...HEAD— passed.origin/main..HEAD— passed for both commits.make update-licenses— blocked before license generation by local Flox/uv sync rebuildingnemo-fabric-runtime; Cargo 1.75.0 cannot parse Rust edition 2024.uv run --no-project --with pre-commit pre-commit run -a— blocked during hook environment setup by GitHub returning 503 forhttps://github.com/norwoodj/helm-docs/on two attempts.Summary by CodeRabbit