Skip to content

chore: relax pin for nss - #127

Merged
mckornfield merged 1 commit into
mainfrom
relax-pin-nss/mck
Jun 1, 2026
Merged

chore: relax pin for nss#127
mckornfield merged 1 commit into
mainfrom
relax-pin-nss/mck

Conversation

@mckornfield

@mckornfield mckornfield commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Extended Python version compatibility for the safe synthesizer plugin to support Python 3.11 through 3.13, enabling broader compatibility with newer Python releases.

Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
@mckornfield
mckornfield requested review from a team as code owners June 1, 2026 18:58

@matthewgrossman matthewgrossman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cca3db80-fb93-4051-b646-40c927ede8a2

📥 Commits

Reviewing files that changed from the base of the PR and between 50b50fc and d35c85d.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • plugins/nemo-safe-synthesizer/pyproject.toml

📝 Walkthrough

Walkthrough

The nemo-safe-synthesizer plugin's requires-python constraint is relaxed to accept Python versions up through 3.13, broadening compatibility from a single minor version (3.11) to three consecutive minor versions (3.11–3.13).

Changes

Python version compatibility

Layer / File(s) Summary
Python version requirement
plugins/nemo-safe-synthesizer/pyproject.toml
The requires-python metadata constraint expanded from >=3.11,<3.12 to >=3.11,<3.14, allowing Python 3.12 and 3.13.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: relax pin for nss' directly matches the changeset: relaxing the Python version constraint in the nemo-safe-synthesizer plugin from <3.12 to <3.14.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch relax-pin-nss/mck

Comment @coderabbitai help to get the list of available commands and usage tips.

@mckornfield
mckornfield enabled auto-merge June 1, 2026 19:04
@mckornfield
mckornfield added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit 52c0d77 Jun 1, 2026
22 of 23 checks passed
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 18422/24402 75.5% 62.0%
Integration Tests N/A N/A N/A

@coderabbitai coderabbitai Bot mentioned this pull request Jun 9, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants