build(web): sync KUI kaizen-ui skill on install - #1247
Merged
Conversation
Run the design-system's sync-skills.mjs from the web root during postinstall so the kaizen-ui skill lands deterministically in web/.agents/skills regardless of where pnpm install is invoked. Removes the studio-package script that relied on INIT_CWD leaking through pnpm --filter. Documents the auto-sync in web/README.md and web/AGENTS.md. Signed-off-by: Aaron Hunt <aahunt@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe web package now synchronizes the KUI ChangesKUI skill synchronization
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/AGENTS.md`:
- Line 13: Update the synchronization documentation in web/AGENTS.md to include
the concrete manual refresh command “pnpm sync-skills” run from the web
directory, while preserving the existing automatic synchronization guidance.
In `@web/package.json`:
- Around line 9-10: Update the sync-skills script in package.json to remove the
unconditional “|| true” fallback so synchronizer failures propagate and cause
installation to fail, preserving the documented requirement that
web/.agents/skills/kaizen-ui is available after install.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3237f985-1a8f-4d5a-af2c-fc890429d79a
📒 Files selected for processing (4)
web/.gitignoreweb/AGENTS.mdweb/README.mdweb/package.json
Contributor
|
Replace the hardcoded node_modules path to sync-skills.mjs with 'pnpm --filter nemo-studio-ui exec kui-sync-skills', which resolves the bin from studio's node_modules/.bin instead of a brittle internal path. Signed-off-by: Aaron Hunt <aahunt@nvidia.com>
Match web/README.md by noting 'pnpm sync-skills' from web/ as the manual refresh command for the kaizen-ui skill. Signed-off-by: Aaron Hunt <aahunt@nvidia.com>
steramae-nvidia
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Installing dependencies will now also sync the
kaizen-uiskills toweb/.agents/skills/kaizen-uito give coding agents clear documentation for working with KUI.Related Issue
Changes
web/package.json: add rootsync-skillsscript and chain it intopostinstall. The script resolves the design-system bin viapnpm --filter nemo-studio-ui exec kui-sync-skills --dir .agents || true, avoiding a brittle hardcodednode_modulespath. It is best-effort (|| true): a sync failure still prints to stderr but does not failpnpm install, since the skill is gitignored agent documentation rather than a build/runtime artifact.web/.gitignore: keep the generated skill (.agents/skills/kaizen-ui/) ignored.web/README.md,web/AGENTS.md: document that install syncskaizen-uifrom the design-system package and thatpnpm sync-skillsfromweb/refreshes it after a package upgrade.Type of Change
Quality Gates
@nvidia/foundations-react-core@1.7.0package (see Verification).Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
pnpm installfromweb/—postinstallranpnpm --filter nemo-studio-ui exec kui-sync-skills --dir .agents, which resolved the bin from studio'snode_modules/.binand reportedkaizen-ui: already up-to-date (v4).jq -e . web/package.json— valid JSON.origin/main..HEAD— OK.Summary by CodeRabbit
Documentation
Chores