chore(licenses): add cut-cross-entropy 25.1.1 license notices - #1243
Merged
Conversation
ironcommit
force-pushed
the
add-cut-cross-entropy-notices/rsadler
branch
from
August 11, 2026 21:47
d27ef47 to
22b01e4
Compare
ironcommit
enabled auto-merge
August 11, 2026 21:49
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdded licensing, provenance, acknowledgment, and license-override records for the transitive ChangesDependency licensing
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@NOTICE`:
- Around line 71-77: Align the cut-cross-entropy metadata across overrides.yaml
and NOTICE: obtain and apply the approved classification instead of APSL-2.0,
add the matching License entry referencing
LICENSES/cut-cross-entropy-25.1.1.txt, and document any verified dual-license
basis.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4c5b874e-c107-4af9-90a0-389814e6265f
📒 Files selected for processing (2)
LICENSES/cut-cross-entropy-25.1.1.txtNOTICE
anastasia-nesterenko
approved these changes
Aug 11, 2026
mckornfield
approved these changes
Aug 11, 2026
Contributor
|
Signed-off-by: Ryan S <267728323+ironcommit@users.noreply.github.com>
ironcommit
force-pushed
the
add-cut-cross-entropy-notices/rsadler
branch
from
August 12, 2026 16:54
22b01e4 to
54f7819
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds license and attribution notices for the cut-cross-entropy 25.1.1 transitive dependency (via Unsloth) to comply with Apple's upstream license requirements.
Changes
LICENSES/cut-cross-entropy-25.1.1.txtcontaining Apple's license text and the upstreamACKNOWLEDGEMENTS.md(PyTorch, Triton, Transformers) that the PyPI wheel omitsNOTICEto document the dependency scope (Linux GPU runtime), source URLs, and point to the new license fileType of Change
Quality Gates
Verification
Signed-off-by:trailerSummary by CodeRabbit
cut-cross-entropycomponent.