feat(studio): Refactor Studio SideNav - #1209
Merged
Merged
Conversation
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR replaces navigation item rendering with shared link and expandable components. It unifies drawer scrolling, adds collapsed-rail flattening, reorganizes workspace navigation groups, and adds route-aware expansion and interaction coverage. ChangesNavigation drawer restructuring
Sequence Diagram(s)sequenceDiagram
participant WorkspaceSideNav
participant NavigationDrawer
participant NavItem
participant ExpandableNavItem
participant NavSubItem
WorkspaceSideNav->>NavigationDrawer: Pass grouped navigation and route state
NavigationDrawer->>NavItem: Render each item
NavItem->>ExpandableNavItem: Render grouped item
ExpandableNavItem->>NavSubItem: Render visible sub-items
ExpandableNavItem->>ExpandableNavItem: Toggle disclosure state
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@web/packages/studio/src/components/Layouts/NavigationDrawer/components/CollapsedNavItem.tsx`:
- Line 28: Update the collapsed-mode VerticalNavListItem usage in
CollapsedNavItem to forward the caller-provided list-item attributes, matching
NavLinkItem and ExpandableNavItem. Preserve the existing collapsed rendering
while ensuring ARIA, data, class, and other VerticalNavListItem props reach the
rendered list item.
In `@web/packages/studio/src/routes/WorkspaceLayout/WorkspaceSideNav.test.tsx`:
- Around line 44-53: Update the expected section list in the
renders-six-RFC-sections test to include the “Evaluations” heading, while
preserving the existing assertions for the other sections and superseded
headings.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 62337fca-c403-4d70-965a-dde2de3f52d0
📒 Files selected for processing (15)
web/packages/studio/src/components/Layouts/NavigationDrawer/components/CollapsedNavItem.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/components/NavItem.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/components/NavItem/ExpandableNavItem.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/components/NavItem/NavLinkItem.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/components/NavItem/NavSubItem.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/components/NavItem/index.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/components/StudioNavItem.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/index.test.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/index.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/styles.tsweb/packages/studio/src/components/Layouts/NavigationDrawer/types.tsweb/packages/studio/src/components/Layouts/NavigationDrawer/utils.tsweb/packages/studio/src/routes/WorkspaceLayout/WorkspaceSideNav.test.tsxweb/packages/studio/src/routes/WorkspaceLayout/WorkspaceSideNav.tsxweb/packages/studio/src/routes/groups/agentRoutes.tsx
💤 Files with no reviewable changes (1)
- web/packages/studio/src/components/Layouts/NavigationDrawer/components/NavItem.tsx
Contributor
|
rrhyne
approved these changes
Aug 10, 2026
rrhyne
left a comment
rrhyne
left a comment
Contributor
There was a problem hiding this comment.
Some things we decided to address after the merge, but otherwise, looks great.
steramae-nvidia
approved these changes
Aug 10, 2026
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-08-10.at.1.13.11.PM.mov
Summary
Related Issue
Changes
Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
Summary by CodeRabbit
New Features
Improvements