fix(studio): show spans while trace details arrive - #1182
Merged
BrianNewsom merged 2 commits intoAug 10, 2026
Merged
Conversation
Signed-off-by: Brian Newsom <brnewsom@nvidia.com>
Contributor
📝 WalkthroughWalkthroughThe session detail flow now synthesizes missing trace summaries from spans and renders available activity when detailed trace data is loading or unavailable. Tests cover arriving activity, not-found, and activity-loading error states. ChangesTrace summary fallback handling
Sequence Diagram(s)sequenceDiagram
participant SessionDetailView
participant TraceDetailView
participant TraceSummary
SessionDetailView->>TraceDetailView: pass trace summary status and error
TraceDetailView->>TraceSummary: render available summary activity
TraceSummary-->>TraceDetailView: provide summary data
TraceDetailView-->>SessionDetailView: render loading, partial, error, or not-found state
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/studio/src/components/IntakeDetail/SessionDetailView.tsx`:
- Line 183: Distinguish unresolved or failed span-summary requests from
successful empty summaries: in
web/packages/studio/src/components/IntakeDetail/SessionDetailView.tsx:183, pass
explicit summary resolution and error state into TraceDetailView; in
web/packages/studio/src/components/IntakeDetail/TraceDetailView.tsx:76-80,
render “Trace Not Found” only for a successfully resolved empty summary and
otherwise show loading or error state; add coverage for a 404 trace detail
combined with a failed span-summary request in
web/packages/studio/src/routes/IntakeSessionDetailRoute/index.test.tsx:443-478.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 277eafa3-9080-4ec4-bc35-72acd46355d9
📒 Files selected for processing (4)
web/packages/studio/src/components/IntakeDetail/SessionDetailView.tsxweb/packages/studio/src/components/IntakeDetail/TraceDetailView.tsxweb/packages/studio/src/components/IntakeDetail/useSessionTrajectories.tsweb/packages/studio/src/routes/IntakeSessionDetailRoute/index.test.tsx
Signed-off-by: Brian Newsom <brnewsom@nvidia.com>
Contributor
|
shanaiabuggy
approved these changes
Aug 10, 2026
BrianNewsom
deleted the
brnewsom/nmp-18-i-dont-have-permission-to-access-the-trace-associated-with
branch
August 10, 2026 23:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Studio now renders activity already received for a session even when its trace details are not available yet. Previously, a direct trace link showed "Trace Not Found" and hid those spans; it now shows the available span tree with a brief informational banner, while genuinely missing traces still use the existing not-found view.
Changes
Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
pnpm --filter nemo-studio-ui test src/routes/IntakeSessionDetailRoute/index.test.tsx— 14 tests passed.pnpm --filter nemo-studio-ui test:ci— 313 test files and 2,835 tests passed with coverage enabled.pnpm --filter nemo-studio-ui typecheck— passed.pnpm --filter nemo-studio-ui lint— passed.pnpm --filter nemo-studio-ui format— passed.uv run pre-commit run -a— all hooks passed.Manual reproduction represented by the route regression test:
Summary by CodeRabbit
Improvements
Tests