fix(studio): Logs overflow and files table in SimpleFilesTable - #1172
Merged
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
Contributor
📝 WalkthroughWalkthroughThe pull request adds a reusable leading-ellipsis component, updates ChangesFile table rendering and interaction
Log viewer sizing
Sequence Diagram(s)sequenceDiagram
participant SimpleFilesTable
participant StudioDataView
participant LeftOverflow
SimpleFilesTable->>StudioDataView: provide filtered and paginated file rows
StudioDataView->>LeftOverflow: render long file names
StudioDataView->>SimpleFilesTable: report row selection
SimpleFilesTable->>SimpleFilesTable: update selected file
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
web/packages/common/src/components/LeftOverflow/index.tsx (1)
1-2: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse a type-only import for
FC.FCis used only as a type. Change the React import toimport type { FC } from 'react';.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/common/src/components/LeftOverflow/index.tsx` around lines 1 - 2, Update the React import in the LeftOverflow component to use a type-only import for FC, since it is referenced only as a type; preserve the existing component implementation.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/common/src/components/LeftOverflow/index.tsx`:
- Line 5: Update the `FC` import in `LeftOverflow` to be type-only, preserving
its existing usage while preventing it from being included as a runtime import.
In `@web/packages/common/src/components/UploadModal/SimpleFilesTable.tsx`:
- Around line 97-104: Synchronize dataViewState.pagination.state.pageIndex with
safePageIndex in the pagination flow around SimpleFilesTable’s pageRows
calculation. When filtering reduces the available page count and the current
page exceeds the last valid index, update the pagination state to the bounded
index while preserving valid page selections.
---
Nitpick comments:
In `@web/packages/common/src/components/LeftOverflow/index.tsx`:
- Around line 1-2: Update the React import in the LeftOverflow component to use
a type-only import for FC, since it is referenced only as a type; preserve the
existing component implementation.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 164bbc46-d20a-4c6e-86dc-ae013812f42a
📒 Files selected for processing (4)
web/packages/common/src/components/LeftOverflow/index.tsxweb/packages/common/src/components/LogViewer/index.tsxweb/packages/common/src/components/UploadModal/SimpleFilesTable.test.tsxweb/packages/common/src/components/UploadModal/SimpleFilesTable.tsx
💤 Files with no reviewable changes (1)
- web/packages/common/src/components/UploadModal/SimpleFilesTable.test.tsx
Contributor
|
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
steramae-nvidia
force-pushed
the
steramae/logs-overflow-fix
branch
from
August 7, 2026 20:39
2fa2fc5 to
8733b38
Compare
marcusds
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sean Teramae steramae@nvidia.com
Summary
Related Issue
Changes
Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
Summary
Related Issue
Changes
Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
Summary
Related Issue
Changes
Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
Summary by CodeRabbit
Summary by CodeRabbit