test(nemo-agents): add e2e for Fabric backed agents - #1149
Merged
mmogallapalli merged 3 commits intoAug 10, 2026
Merged
Conversation
Signed-off-by: Manjesh Mogallapalli <mmogallapall@nvidia.com>
mmogallapalli
marked this pull request as ready for review
August 6, 2026 22:25
Contributor
📝 WalkthroughWalkthroughThe shared deployment helper now supports subprocess, Docker, and Kubernetes deployments with NAT and Fabric configuration formats. It adds mode-specific endpoint validation and preserves the container wrapper. E2E coverage now includes both formats across all three deployment modes. Fabric staging handles plugin-client not-found errors. ChangesAgent deployment and invocation
Fabric artifact staging
Sequence Diagram(s)sequenceDiagram
participant E2ETest
participant DeploymentHelper
participant DeploymentMode
participant Gateway
participant AgentRuntime
E2ETest->>DeploymentHelper: select NAT or Fabric configuration
DeploymentHelper->>DeploymentMode: start subprocess, Docker, or Kubernetes deployment
DeploymentMode-->>DeploymentHelper: return endpoint and process state
DeploymentHelper->>Gateway: invoke deployed agent
Gateway->>AgentRuntime: route agent request
AgentRuntime-->>Gateway: return response
Gateway-->>E2ETest: return invocation result
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
|
Signed-off-by: Manjesh Mogallapalli <mmogallapall@nvidia.com>
mikeknep
approved these changes
Aug 10, 2026
mmogallapalli
deleted the
mmogallapall/aircore-960-add-e2e-tests-for-fabric-backed-agent-serving-across
branch
August 10, 2026 15:44
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add deterministic Fabric/DeepAgents E2E deployment coverage alongside the existing NAT scenarios for subprocess, Docker, and Kubernetes. The tests exercise agent registration, backend-specific readiness, invocation through the standard agents gateway, deterministic mock-provider output, and the existing cleanup paths without installing dependencies dynamically.
Related Issue
Closes AIRCORE-960.
Changes
nemo-agents-spec-v1configs across subprocess and container backends.nemo_platform_pluginclient 404 raised for an absent Fabric spec fileset so inlineagent.yamlstaging falls back as intended.Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
uv run --frozen pytest e2e/test_nemo_agents_subprocess.py -v --run-e2e --no-cov— 2 passed.nmp-local/nmp-api:e2eimage and temporary Docker Desktop harness overrides; those local overrides are not part of this branch.NMP_E2E_IMAGE_REGISTRY=nmp-local NMP_E2E_IMAGE_TAG=e2e uv run --frozen pytest e2e/test_nemo_agents_docker.py::test_fabric_docker_agent_deploys_and_invokes_through_gateway -v --run-e2e --no-cov— 1 passed.NMP_BASE_URL=http://127.0.0.1:8080 NMP_E2E_IMAGE_REGISTRY=nmp-local NMP_E2E_IMAGE_TAG=e2e uv run --frozen pytest e2e/test_nemo_agents_k8s.py -v --run-e2e --no-covagainst a local Kind deployment — 2 passed..venv/bin/pytest plugins/nemo-agents/tests/unit/test_fabric_artifact_staging.py -v --no-cov— 9 passed.Summary by CodeRabbit
New Features
Bug Fixes
Tests