docs: make bash get treated correctly - #1143
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe throughput tutorial dependency-installation cells now explicitly use ChangesThroughput tutorial notebook
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/fern/components/notebooks/optimize-throughput.ts`:
- Around line 41-43: Update the notebook conversion logic in
ipynb-to-fern-json.py to detect cells whose source begins with %%bash and assign
them Bash rather than Python, ensuring source_html is regenerated with Bash
highlighting. Then regenerate optimize-throughput.ts so its language metadata
and highlighted HTML match the Bash cell.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7d31093c-5099-47fb-91af-a0bee10e001b
📒 Files selected for processing (2)
docs/fern/components/notebooks/optimize-throughput.jsondocs/fern/components/notebooks/optimize-throughput.ts
Signed-off-by: Aaron Gabow <agabow@nvidia.com>
Signed-off-by: Aaron Gabow <agabow@nvidia.com>
c196018 to
f21b6a0
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Summary
Related Issue
Changes
Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
Summary by CodeRabbit