docs: document analyst agent name requirement - #1140
Merged
BrianNewsom merged 4 commits intoAug 7, 2026
Merged
Conversation
Signed-off-by: Brian Newsom <brnewsom@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughDocumentation defines stable agent naming, configured-agent query matching, ingestion verification, and routing for named leaderboard workflows. ChangesNeMo Insights telemetry guidance
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Brian Newsom <brnewsom@nvidia.com>
aleckhoury
approved these changes
Aug 6, 2026
Signed-off-by: Brian Newsom <brnewsom@nvidia.com>
BrianNewsom
enabled auto-merge
August 6, 2026 21:31
…-agentname-attr-is-not-set
Contributor
|
BrianNewsom
deleted the
brnewsom/ase-795-agent-analysis-fails-if-the-agentname-attr-is-not-set
branch
August 7, 2026 03:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document that NeMo Insights requires Intake spans to have a normalized
agent_namematching the configured analyst agent. Telemetry without the attribute can ingest successfully but is excluded from the analyst queries used to retrieve and group spans.Related Issue
ASE-795
Changes
gen_ai.agent.name,llm.agent.name, andagent.name.agent_nameverification step to thenemo-intakeskill and synchronize its vendored SDK copy.Type of Change
Quality Gates
agent_namescoping and session grouping; Intake catalog tests verify semantic attribute normalization and query construction.Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
uv run pre-commit run -a— passed.uv run --frozen pytest plugins/nemo-insights/tests/test_analyst_agent.py::test_nooa_read_method_preserves_run_scope plugins/nemo-insights/tests/test_periodic_analysis.py::test_count_agent_sessions_uses_server_side_session_groups services/intake/tests/test_spans_span_attribute_catalog.py -q— 39 passed.nemo-intakeskill files are byte-identical.Summary by CodeRabbit