docs(optimization): add docker sandbox patterns for isolating experimentalist - #1084
Conversation
Document an isolated laptop workflow while preserving the current architecture caveat. Signed-off-by: Nico Tonozzi <ntonozzi@nvidia.com>
Signed-off-by: Brian Newsom <brnewsom@nvidia.com>
Signed-off-by: Brian Newsom <brnewsom@nvidia.com> # Conflicts: # docs/get-started/example-agent.mdx # plugins/nemo-experimentalist/README.md
Signed-off-by: Brian Newsom <brnewsom@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-1084-pr-1034-sandbox.docs.buildwithfern.com/nemo-platform |
📝 WalkthroughWalkthroughThe documentation replaces direct host execution with Docker Sandbox execution for the Experimentalist. It adds versioned prerequisites, environment forwarding, host service access, security limitations, artifact handling, and sandbox lifecycle commands. ChangesExperimentalist Sandbox Documentation
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/get-started/example-agent.mdx`:
- Around line 178-181: Add a final “## Next Steps” section to the tutorial after
the existing sbx cleanup commands, including canonical Fern links to relevant
related guides. Ensure this section is the last content in the page and follows
the documentation cross-linking guidelines.
- Around line 167-172: Add concrete sbx commands in
docs/get-started/example-agent.mdx lines 167-172 to inspect run.json, compare
the agent-0 and agent-1 directories, and copy retained artifacts from the
sandbox to the host. In plugins/nemo-experimentalist/README.md lines 99-104, add
the artifact-copy command or link to the complete guide.
- Around line 156-164: Require a sanitized checkout in both documented flows:
update docs/get-started/example-agent.mdx lines 156-164 and
plugins/nemo-experimentalist/README.md lines 88-97 to ensure unrelated secrets
are absent from the Git root before sandbox creation, and keep credentials
outside the repository when needed. Preserve the existing warning while
documenting this requirement for each flow.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4bbce0ce-7edc-48cc-b262-aff99a847e28
📒 Files selected for processing (2)
docs/get-started/example-agent.mdxplugins/nemo-experimentalist/README.md
Signed-off-by: Brian Newsom <brnewsom@nvidia.com>
|
Summary
Test plan
Summary by CodeRabbit