-
Notifications
You must be signed in to change notification settings - Fork 20
feat(studio): add CardSelect; update DataView toolbar and entityName tests #1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
02fd3a7
feat(studio): add CardSelect component; update DataView toolbar and t…
nv-odrulea 0aa0870
fix(studio): drop CardSelect, update RadioCard to handle it
nv-odrulea 123f10e
fix(studio): import fix, remove extra comments
nv-odrulea b6d624e
fix(studio): scope css selector to the component so nested items can'…
nv-odrulea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
web/packages/common/src/components/RadioCard/index.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { RadioGroupRoot } from '@nvidia/foundations-react-core'; | ||
| import { render, screen } from '@testing-library/react'; | ||
| import userEvent from '@testing-library/user-event'; | ||
|
|
||
| import { RadioCard } from '.'; | ||
|
|
||
| const renderGroup = (onValueChange: () => void, showIndicator?: boolean) => { | ||
| render( | ||
| <RadioGroupRoot name="test-group" value="a" onValueChange={onValueChange}> | ||
| <RadioCard value="a" label="Option A" description="First" showIndicator={showIndicator} /> | ||
| <RadioCard value="b" label="Option B" description="Second" showIndicator={showIndicator} /> | ||
| </RadioGroupRoot> | ||
| ); | ||
| }; | ||
|
|
||
| describe('RadioCard', () => { | ||
| it('Renders a radio per card with its label and description by default', () => { | ||
| renderGroup(vi.fn()); | ||
|
|
||
| expect(screen.getAllByRole('radio')).toHaveLength(2); | ||
| expect(screen.getByRole('radio', { name: 'Option A' })).toBeChecked(); | ||
| expect(screen.getByText('First')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| // The hidden indicator must stay in the DOM: four studio suites locate these | ||
| // cards with getByRole('radio'). | ||
| it('Keeps the radio input queryable and operable when showIndicator is false', async () => { | ||
| const user = userEvent.setup(); | ||
| const onValueChange = vi.fn(); | ||
| renderGroup(onValueChange, false); | ||
|
|
||
| const optionB = screen.getByRole('radio', { name: 'Option B' }); | ||
| expect(optionB).toBeInTheDocument(); | ||
| expect(optionB).not.toBeChecked(); | ||
|
|
||
| await user.click(screen.getByText('Option B')); | ||
|
|
||
| expect(onValueChange).toHaveBeenCalledWith('b'); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.