chore(customizer): update RL image - #1017
Conversation
Signed-off-by: anubhutiv <anubhutiv@nvidia.com>
📝 WalkthroughWalkthroughThe RL image now pins a new NeMo-RL commit, prefetches and validates sandbox actor venvs, and disables Gym environment prefetching by default. Documentation and GPU smoke coverage reflect the seven-actor configuration and runtime environment installation. ChangesRL image prefetch behavior
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docker/rl/Dockerfile.nmp-rl-base (1)
334-354: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winProvide a writable runtime uv cache.
Line 340 installs built-in environments at runtime by default. The published base runs as UID 1000, but
/opt/uv_cacheremains read-only. A directnmp-rl-baseconsumer can fail when uv must cache dependencies for a runtime environment install.Set a writable runtime cache in this image, or do not present this stage as directly runnable for Gym workloads.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docker/rl/Dockerfile.nmp-rl-base` around lines 334 - 354, Update the NeMo-Gym environment setup around NEMO_GYM_PREFETCH_CONFIGS and /opt/gym_venvs to provide a writable /opt/uv_cache for the published UID 1000 runtime; ensure ownership and permissions allow uv dependency caching during first-use environment installation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/smoke_gpu/test_rl_training.py`:
- Around line 69-89: Add “tenacity” to the import requirement lists for NemoGym,
SandboxedGymActor, and SandboxEpisodeBrokerActor in the environment dependency
assertions. Preserve all existing entries, including nemo_gym, opensandbox, and
each actor-specific module.
---
Outside diff comments:
In `@docker/rl/Dockerfile.nmp-rl-base`:
- Around line 334-354: Update the NeMo-Gym environment setup around
NEMO_GYM_PREFETCH_CONFIGS and /opt/gym_venvs to provide a writable /opt/uv_cache
for the published UID 1000 runtime; ensure ownership and permissions allow uv
dependency caching during first-use environment installation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 79ddd3c0-06bf-4227-9de2-a3b50783110b
📒 Files selected for processing (4)
docker-bake.hcldocker/rl/Dockerfile.nmp-rl-basedocker/rl/README.mdtests/smoke_gpu/test_rl_training.py
|
svvarom
left a comment
There was a problem hiding this comment.
LGTM - we have builds hanging rn - https://github.com/NVIDIA-NeMo/Platform-Deploy/actions/runs/30647335761. This will help fix it
Summary by CodeRabbit
New Features
Documentation
Tests