Repository navigation
chore(plugin): move image helpers to plugin package #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
34 changes: 34 additions & 0 deletions
34
packages/nemo_platform_plugin/src/nemo_platform_plugin/jobs/image.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Image helper utilities for NeMo Platform jobs.""" | ||
|
|
||
| from collections.abc import Callable | ||
|
|
||
| from nemo_platform_plugin.config import get_platform_config | ||
|
|
||
|
|
||
| def get_qualified_image(name: str, tag: str | None = None, registry: str | None = None) -> str: | ||
| """Get a fully qualified Docker image name. | ||
|
|
||
| Builds an image reference in the format: {registry}/{name}:{tag} | ||
| """ | ||
| config = get_platform_config() | ||
|
|
||
| effective_registry = registry if registry is not None else config.image_registry | ||
| effective_tag = tag if tag is not None else config.image_tag | ||
|
|
||
| return f"{effective_registry}/{name}:{effective_tag}" | ||
|
|
||
|
|
||
| def image_builder(registry: str | None = None, tag: str | None = None) -> Callable[[str], str]: | ||
| """Create a function that builds qualified image names with preset registry and tag.""" | ||
| config = get_platform_config() | ||
|
|
||
| effective_registry = registry if registry is not None else config.image_registry | ||
| effective_tag = tag if tag is not None else config.image_tag | ||
|
|
||
| def _build(name: str) -> str: | ||
| return f"{effective_registry}/{name}:{effective_tag}" | ||
|
|
||
| return _build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from types import SimpleNamespace | ||
|
|
||
| import nemo_platform_plugin.jobs.image as image | ||
| import pytest | ||
| from nemo_platform_plugin.jobs.image import get_qualified_image, image_builder | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def platform_config(monkeypatch: pytest.MonkeyPatch) -> None: | ||
| config = SimpleNamespace(image_registry="registry.example.com/nemo", image_tag="test-tag") | ||
| monkeypatch.setattr(image, "get_platform_config", lambda: config) | ||
|
|
||
|
|
||
| def test_get_qualified_image_uses_platform_config(platform_config: None) -> None: | ||
| assert get_qualified_image("nmp-cpu-tasks") == "registry.example.com/nemo/nmp-cpu-tasks:test-tag" | ||
|
|
||
|
|
||
| def test_get_qualified_image_accepts_overrides(platform_config: None) -> None: | ||
| assert ( | ||
| get_qualified_image("nmp-cpu-tasks", registry="nvcr.io/example", tag="25.10") | ||
| == "nvcr.io/example/nmp-cpu-tasks:25.10" | ||
| ) | ||
|
|
||
|
|
||
| def test_image_builder_uses_platform_config_once(platform_config: None) -> None: | ||
| build_image = image_builder() | ||
|
|
||
| assert build_image("nmp-api") == "registry.example.com/nemo/nmp-api:test-tag" | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.