Repository navigation
fix(platform-plugin): declare the filesets dependency the package imports - #2044
maxdubrinsky wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughThe plugin now declares ChangesFilesets dependency registration
Suggested reviewers: Priority: ➖ Normal Change: Bug fix Merge Risk: ⚪ Minimal · up to Filesets is available in workspace installs and bundled wheel builds without a concrete merge-blocking issue. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
…orts nemo_platform_plugin.jobs.result_manager imports filesets, but nemo-platform-plugin only bundled it at wheel-build time and never declared it. A workspace sync scoped to one package (uv run --package nemo-deployments-plugin) therefore had no filesets module, and importing nemo_platform_plugin.discovery failed with ModuleNotFoundError. The path-filtered "Deployments OpenShell backend tests" CI job is the first to run that way since the import landed in #1137, which is why main never saw it. The nemo-platform metapackage's generated nemo-platform-plugin extra picks up the same dependency via make vendor. The built plugin wheel is unchanged: the bundler rewrites the new requirement into the nemo-platform-plugin[nemo-platform-sdk] extra it already emits. Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
9e2fce5 to
bb70b92
Compare
|
This PR has had no activity for 30 days. It will be closed after another 7 days without activity. Please comment or push an update if you plan to continue. Maintainers can add |
|
Closing this PR after 7 additional days without activity. Please reopen it when you're ready to continue. |
Summary
nemo_platform_plugin.jobs.result_managerimportsfilesets, butnemo-platform-pluginonly bundles it at wheel-build time and never declares it as a dependency. A workspace sync scoped to one package (uv run --package nemo-deployments-plugin ...) therefore has nofilesetsmodule, and importingnemo_platform_plugin.discoveryfails withModuleNotFoundError. This declares the dependency.Changes
packages/nemo_platform_plugin/pyproject.toml: addfilesets(workspace source) todependencies.packages/nemo_platform/pyproject.toml: the generatednemo-platform-pluginextra picks upfilesets(output ofmake vendor, whichlint-sdk-vendoredenforces).uv.lock: the resulting edges, locked with uv 0.9.14 viascript/uv-lock.sh.The path-filtered "Deployments OpenShell backend tests" job is the first CI job to sync a single package since the import landed in #1137, which is why
mainnever surfaced it. It fails today on #1956 for this reason.The built wheel is unchanged: the bundler rewrites the new requirement into the
nemo-platform-plugin[nemo-platform-sdk]extra it already emits, andRequires-Distmetadata is byte-identical before and after.Type of Change
Quality Gates
make test-deployments-openshellis the failing check and now passes (test_openshell_profile_is_discoverableimportsnemo_platform_plugin.discoveryin the scoped env).Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
make test-deployments-openshell: 122 passed (was 1 failed, 126 passed on the same job for fix(deployments): dial openshell sandbox services through the gateway by Host header #1956)uv build --package nemo-platform-plugin --wheelon this branch and onmain:Requires-Distlines identicalbash script/uv-lock.shwith uv 0.9.14: lock diff is four lines,uv lock --checkcleanuv run pre-commit run -a: not run locally (full-repo hooks); CI covers itSummary by CodeRabbit
filesetsdependency and configured it as a workspace source.filesetsavailable where supported.