Repository navigation
chore: remove unused perl packages and bump cryptography to 50.x - #1091
Conversation
995173b to
89d8986
Compare
📝 WalkthroughWalkthroughThe project and container definitions now require ChangesCVE Remediation
Jobs Launcher Dependency Refresh
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docker/Dockerfile.auditor-tasks`:
- Around line 97-106: Update the perl_packages pattern in the purge command and
the final dpkg-query verification to include all installed Perl module packages,
including names matching lib*-perl such as libxml-parser-perl. Preserve the
existing purge, file cleanup, and final absence checks while ensuring both
package discovery and verification cover the same complete set of Perl-related
packages.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c35f5535-070b-499b-9c5b-bce75fed606c
📒 Files selected for processing (1)
docker/Dockerfile.auditor-tasks
|
89d8986 to
21961eb
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
21961eb to
eb6c093
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docker/scripts/cve-cleanup.sh (1)
40-40: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse argument-safe expansion for the purge.
perl_packagesis a newline-delimited list. Under Bash, the unquoted expansion at Line 40 is subject to word splitting and filename expansion. (gnu.org) Use a shell array or controlledxargs -r, then pass each package as a separate argument. Do not quote the current scalar directly because that would pass all package names as one argument.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docker/scripts/cve-cleanup.sh` at line 40, Update the purge command in the cve-cleanup script to pass each entry from perl_packages as a separate argument using a shell array or controlled xargs -r; avoid both unquoted scalar expansion and quoting the entire newline-delimited value as one package argument.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docker/scripts/cve-cleanup.sh`:
- Line 40: Update the purge command in the cve-cleanup script to pass each entry
from perl_packages as a separate argument using a shell array or controlled
xargs -r; avoid both unquoted scalar expansion and quoting the entire
newline-delimited value as one package argument.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3460bd5c-c901-4128-b0ac-ae7e60b44968
⛔ Files ignored due to path filters (2)
services/core/jobs/jobs-launcher/go.sumis excluded by!**/*.sumuv.lockis excluded by!**/*.lock
📒 Files selected for processing (7)
docker/Dockerfile.auditor-tasksdocker/Dockerfile.safe-synthesizer-tasksdocker/automodel/Dockerfile.nmp-automodel-basedocker/scripts/cve-cleanup.shplugins/nemo-safe-synthesizer/constraints.txtpyproject.tomlservices/core/jobs/jobs-launcher/go.mod
🚧 Files skipped from review as they are similar to previous changes (5)
- docker/automodel/Dockerfile.nmp-automodel-base
- docker/Dockerfile.safe-synthesizer-tasks
- pyproject.toml
- docker/Dockerfile.auditor-tasks
- plugins/nemo-safe-synthesizer/constraints.txt
Signed-off-by: Ryan S <267728323+ironcommit@users.noreply.github.com>
eb6c093 to
4fc1029
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Signed-off-by: Ryan S <267728323+ironcommit@users.noreply.github.com> Signed-off-by: Aaron Gabow <agabow@nvidia.com>
Summary
Reduces CVE surface in container images by removing unused Perl packages, upgrading
cryptographyto 50.x, and trimming unused Go dependencies in the jobs launcher.Changes
Perl removal
Dockerfile.auditor-tasks: Inline purge ofperl-base,perl,perl-modules-*, andlibperl*with build-time assertions thatperlis no longer onPATHand no CVE-tracked Perl packages remain installed.docker/scripts/cve-cleanup.sh: Added reusable Perl CVE cleanup block that removes Perl packages, verifies removal, and fails the build if any remain. Intended for images that source this script during build.cryptography48 → 50cryptographyconstraint from>=48.0.1,<49to>=50.0.0,<51across:pyproject.toml(constraint-dependencies + override-dependencies)Dockerfile.auditor-tasksDockerfile.safe-synthesizer-tasksDockerfile.nmp-automodel-baseplugins/nemo-safe-synthesizer/constraints.txtuv.lockupdated accordingly.Jobs launcher dependency cleanup
go.opentelemetry.io/contrib/exporters/autoexportand all transitive Prometheus/gRPC exporter dependencies that were no longer needed.google.golang.org/grpcfrom 1.81.1 to 1.83.0 andgolang.org/x/textfrom 0.38.0 to 0.39.0.go.sumupdated accordingly.