Skip to content

fix: Delete an unnecessary callback, fix default log level - #471

Merged
grahamking merged 1 commit into
mainfrom
gk-remove-callback
Aug 18, 2026
Merged

fix: Delete an unnecessary callback, fix default log level#471
grahamking merged 1 commit into
mainfrom
gk-remove-callback

Conversation

@grahamking

@grahamking grahamking commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

The callback was only for rand algorithm to provide a slightly different log
message.

Changed the default log level to be info. Previously we had it as info for
specific crates but no default, so other crate's logs were discarded.

Reviewed-by: Cursor:Grok 4.6 xhigh

Signed-off-by: Graham King grahamk@nvidia.com

Summary by CodeRabbit

  • Observability
    • Routing logs now present algorithm, target, confidence, and routing tier in structured fields for clearer diagnostics.
    • Default informational logging is broadened across the service while keeping OpenTelemetry messages limited to warnings.
  • Maintenance
    • Removed legacy decision-message customization from fall-through and random routing behavior, simplifying routing configuration without changing routing outcomes.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1

🚀 View preview at
https://NVIDIA-NeMo.github.io/Switchyard/pr-preview/pr-471/

Built to branch gh-pages at 2026-08-18 17:24 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

The callback was only for `rand` algorithm to provide a slightly different log
message.

Changed the default log level to be info. Previously we had it as info for
specific crates but no default, so other crate's logs were discarded.

Reviewed-by: Cursor:Grok 4.6 xhigh

Signed-off-by: Graham King <grahamk@nvidia.com>
@grahamking grahamking changed the title fix: Delete an unnecessary callback fix: Delete an unnecessary callback, fix default log level Aug 18, 2026
@grahamking
grahamking marked this pull request as ready for review August 18, 2026 17:23
@grahamking
grahamking requested a review from a team as a code owner August 18, 2026 17:23
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: eb449703-fdc8-4bf6-a7b3-a6325a6baa70

📥 Commits

Reviewing files that changed from the base of the PR and between 0cf6439 and 625a894.

📒 Files selected for processing (3)
  • crates/libsy/src/algorithms/fall_through.rs
  • crates/libsy/src/algorithms/rand.rs
  • crates/switchyard-server/src/observability.rs
💤 Files with no reviewable changes (1)
  • crates/libsy/src/algorithms/rand.rs

Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review.


Walkthrough

The change removes configurable decision-reason callbacks from routing algorithms, replaces formatted routing messages with structured tracing fields, and broadens the default server log filter to global info.

Changes

Routing logging cleanup

Layer / File(s) Summary
FallThrough decision logging and random routing
crates/libsy/src/algorithms/fall_through.rs, crates/libsy/src/algorithms/rand.rs
FallThrough no longer stores or configures decision-reason callbacks. Routing logs use structured target, confidence, and routing-tier fields. Random retains classifier wiring without custom reason generation.
Default tracing filter
crates/switchyard-server/src/observability.rs
The default filter uses global info logging and retains the opentelemetry=warn override.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 625a8

The PR removes an unnecessary callback and makes the default logging level more inclusive; no actionable merge-blocking risk remains beyond normal checks and review.

Poem

I’m a rabbit hopping through the logs,
With tidy fields instead of fogs.
No callback carrots in the queue,
Targets and confidence shine through.
Global info guides the way—
Thump, trace, and route all day!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes both main changes: removing the unnecessary callback and correcting the default log level.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@grahamking
grahamking merged commit c7c07d5 into main Aug 18, 2026
25 checks passed
@grahamking
grahamking deleted the gk-remove-callback branch August 18, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants