fix: Delete an unnecessary callback, fix default log level - #471
Conversation
|
The callback was only for `rand` algorithm to provide a slightly different log message. Changed the default log level to be info. Previously we had it as info for specific crates but no default, so other crate's logs were discarded. Reviewed-by: Cursor:Grok 4.6 xhigh Signed-off-by: Graham King <grahamk@nvidia.com>
e956095 to
625a894
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review. WalkthroughThe change removes configurable decision-reason callbacks from routing algorithms, replaces formatted routing messages with structured tracing fields, and broadens the default server log filter to global ChangesRouting logging cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR removes an unnecessary callback and makes the default logging level more inclusive; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
The callback was only for
randalgorithm to provide a slightly different logmessage.
Changed the default log level to be info. Previously we had it as info for
specific crates but no default, so other crate's logs were discarded.
Reviewed-by: Cursor:Grok 4.6 xhigh
Signed-off-by: Graham King grahamk@nvidia.com
Summary by CodeRabbit