docs(stage-router): mark capable_first experimental, and warn at startup - #363
Conversation
Every published threshold and routing result comes from efficient_first runs. capable_first works and the server accepts it, but it has not been benchmarked, so there is no calibrated confidence_threshold for it and no measured accuracy or cost to set expectations against. The docs now list efficient_first first and carry a warning admonition saying so, and the TOML schema table marks capable_first experimental. The server logs a warning at startup when a stage_router route selects it, so the caveat reaches operators who never read the page. Signed-off-by: Sabhatina Selvam <sabhatinas@nvidia.com>
|
WalkthroughThe server now warns when a ChangesStage router picker guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/routing_algorithms/stage_router_routing.md`:
- Around line 70-85: Update the nearby documentation sentence referring to the
“default capable_first picker” so it instead says “the capable_first picker.”
Preserve the surrounding explanation and align the wording with the required
picker configuration and efficient_first recommendation.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2afd415b-ab96-417e-9508-8d070a80c51e
📒 Files selected for processing (3)
crates/switchyard-server/src/config.rsdocs/reference/toml_schema.mddocs/routing_algorithms/stage_router_routing.md
Every published threshold and routing result comes from
efficient_firstruns.capable_firstworks and the server accepts it, but it has not been benchmarked — so there is no calibratedconfidence_thresholdfor it and no measured accuracy or cost to set expectations against.Docs now lead with
efficient_firstand carry a warning admonition; the TOML schema table markscapable_firstexperimental. The server also logs a warning at startup when astage_routerroute selects it, so the caveat reaches operators who never read the page:Verified the warning fires for
capable_firstand stays silent forefficient_first(--dry-runon both).cargo test -p switchyard-server, clippy,cargo fmt --checkandmkdocs build --strictall pass.Summary by CodeRabbit
New Features
capable_firstrouting picker is selected.Documentation
efficient_firstis the recommended picker.efficient_first.capable_firstis unbenchmarked and lacks calibrated metrics.